Closed Bug 377625 Opened 17 years ago Closed 17 years ago

Creating a new test plan causes error and product version not displayed.

Categories

(Testopia :: Test Plans, defect)

x86
Linux
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: scott, Assigned: gregaryh)

References

()

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.2) Gecko/20070220 Firefox/2.0.0.2
Build Identifier: 1.2

We are using bugzilla 2.22, installed testopia 1.2

Testopia is not functional as a result of this bug.

Reproducible: Always

Steps to Reproduce:
1. Click on 'new plan'
2. Enter natural data
3. Verify that screen now displays products but not "Product version" (despite there being product versions for the product selected)
4. Click Add, verify following error message is displayed:

Undef to trick_taint at Bugzilla/Util.pm line 66
	Bugzilla::Util::trick_taint('undef') called at tr_new_plan.cgi line 63
Actual Results:  
Undef to trick_taint at Bugzilla/Util.pm line 66
	Bugzilla::Util::trick_taint('undef') called at tr_new_plan.cgi line 63

Expected Results:  
A page confirming that the test plan had been created

We found that hard-coding the product version allowed us to create a test plan. 

Please note that clicking on environment variables does not display anything on that page I suspect that this is the same problem.

We also tried to install bugzilla 2.22.2 and testopia 1.2 - the same problem occurred (as well as the Testers group not being created - another bug for another day).
I am getting the same error.  When I look at my webserver log I see:

[Thu Apr 19 17:59:06 2007] [error] [client 10.10.##.###] [Thu Apr 19 17:59:06 2007] tr_new_plan.cgi: Argument "" isn't numeric in numeric gt (>) at data/template/template/en/default/testopia/plan/navigate.html.tmpl line 23., referer: http://###<textarea></textarea>.###.##.###/bugzilla-2.22.2/tr_new_plan.cgi
Do you have dojo installed and can you verify that it is working?
Testopia on sp2 (where we tested it) was installed from the latest tarball,
testopia-1.2.tar.gz which contained the dojo libraries.

How do I test if it is working?
I ran the checksetup.pl and this was outputted (no mention of dojo):

Checking perl modules ...
Checking for       AppConfig (v1.52)   ok: found v1.56
Checking for             CGI (v2.93)   ok: found v3.29
Checking for    Data::Dumper (any)     ok: found v2.121
Checking for    Date::Format (v2.21)   ok: found v2.22
Checking for             DBI (v1.38)   ok: found v1.55
Checking for      File::Spec (v0.84)   ok: found v3.24
Checking for      File::Temp (any)     ok: found v0.18
Checking for        Template (v2.12)   ok: found v2.15
Checking for      Text::Wrap (v2001.0131) ok: found v2001.09292
Checking for    Mail::Mailer (v1.67)   ok: found v1.74
Checking for    MIME::Base64 (v3.01)   ok: found v3.07
Checking for    MIME::Parser (v5.406)  ok: found v5.420
Checking for        Storable (any)     ok: found v2.16

The following Perl modules are Required for Testopia:
Checking for      Text::Diff (v0.35)   ok: found v0.35
Checking for            JSON (v1.07)   ok: found v1.09

The following Perl modules are optional:
Checking for              GD (v1.20)   ok: found v2.32
Checking for     Chart::Base (v1.0)    ok: found v2.3
Checking for       XML::Twig (any)     ok: found v3.26
Checking for       GD::Graph (any)     ok: found v1.44
Checking for GD::Text::Align (any)     ok: found v1.18
Checking for     PatchReader (v0.9.4)  ok: found v0.9.5
Checking for   Image::Magick (any)     ok: found v6.0.7
Checking user setup ...

********************************************************************************
WARNING! You have not entered a value for the "webservergroup" parameter
in localconfig. This means that certain files and directories which need
to be editable by both you and the webserver must be world writable, and
other files (including the localconfig file which stores your database
password) must be world readable. This means that _anyone_ who can obtain
local access to this machine can do whatever they want to your Bugzilla
installation, and is probably also able to run arbitrary Perl code as the
user that the webserver runs as.

You really, really, really need to change this setting.
********************************************************************************

Removing existing compiled templates ...
Precompiling templates ...
Checking for      DBD::mysql (v2.9003) ok: found v4.004
Checking for           MySQL (v4.0.14) ok: found v4.1.21-standard
We cannot use testopia until this is working - is testopia in active development or should I look elsewhere to help?

Assuming the worst is there any alternative to testopia?

Can someone supply me with a tgz copy of their (working) copy?
Severity: critical → blocker
We added the following line:
require 'globals.pl';

to the file:

tr_new_plan.cgi

This was based off other post we had found on the web.  This allowed us to move fwd.
Unfortunately this has not fixed our problem. Does 'moving forward' mean working?
Looking further the error message is different now:

Undef to trick_taint at Bugzilla/Util.pm line 66
	Bugzilla::Util::trick_taint('undef') called at tr_new_plan.cgi line 69

But that could just be due to the additional lines of code....
I successfuly fixed the above error by installing dojo as mentioned in above.

You can find the information in the testopia/dojo/DOJO_INSTALL_HELP file
(In reply to comment #5)
> We cannot use testopia until this is working - is testopia in active
> development ...?

Yes it is, but the main developer is rather swamped with other things right now.

My advice -- chat with him on the #testopia channel. See http://landfill.bugzilla.org/irc/ -- he's almost always online during Utah's working hours (US MDT). His name is ghendricks.
On the tr_new_plan.cgi page, if the version is not loading then something is wrong with your dojo installation. Are you seeing any javascript errors on this page?
I have installed the latest version of dojo but it is still a no-go.

I have tested that dojo is working on that site using a demo which comes with the package. Go to http://issuelog.crazycolour.com/dojo/demos/de2.html to try it out.

We are not seeing any errors and we are using firefox 2.0.0.2 on ubuntu linux 
Could someone please tgz their installation of bugzilla and testopia (version 2.22 bugzilla, 1.2 testopia if possible - but anything is welcome!)

Thanks for your help.
can you attach a screenshot of your tr_new_plan.cgi page?
Thanks for your interest - the error produced is:

Undef to trick_taint at Bugzilla/Util.pm line 66
	Bugzilla::Util::trick_taint('undef') called at tr_new_plan.cgi line 69
Do you have any versions defined for this product?
Can you please verify that there are no javascript errors:
1. Open the javascript error console from the tools menu in firefox.
2. Click the "Clear" button to clear out any old errors.
3. Refresh your tr_new_runs.cgi page and copy any error messages you see here.
Yes. There are versions defined for all products.
When running "te_new_plan.cgi", there are two javascript errors as per below
==============================
Error: dojo is not defined
Source File: http://issuelog.crazycolour.com/bugzilla/tr_new_plan.cgi
Line: 105
Error: getProdVers is not defined
Source File: http://issuelog.crazycolour.com/bugzilla/tr_new_plan.cgi
Line: 159 
==============================
Check the permissions on the dojo files. Are they readable by the web server?

you can test by entering the path to the dojo file in your address bar:

http://<yourbugzilla>/testopia/dojo/dojo.js

You can change the permissions on the testopia folder with chgrp
chgrp -R <apachegrp> testopia 
This is not a bug in Testopia. Please email me if you continue to have trouble with this.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → INVALID
Thanks for your reply Greg.

The directory that held dojo had permissions preventing execute access however I can now access the dojo.js script and I get the following error, I cannot change the group.:

Software error:

Undef to trick_taint at Bugzilla/Util.pm line 66
	Bugzilla::Util::trick_taint('undef') called at tr_new_plan.cgi line 69

I don't know why this is not a testopia issue - it didn't work out of the box, and I don't see how you can rule this out as a testopia bug. Are you suggesting that it is a dojo bug? Dojo's tests seem to have worked fine: 

http://issuelog.crazycolour.com/bugzilla/testopia/dojo/tests/test_html.html

I can view the dojo.js file:

http://issuelog.crazycolour.com/bugzilla/testopia/dojo/dojo.js
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(In reply to comment #20)
> 
> Undef to trick_taint at Bugzilla/Util.pm line 66
>         Bugzilla::Util::trick_taint('undef') called at tr_new_plan.cgi line 69
> 
> 

This is a Testopia issue. It has already been fixed on the 1.2.2 branch. I will try to release this weekend.

Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
(In reply to comment #21)
> (In reply to comment #20)
> > 
> > Undef to trick_taint at Bugzilla/Util.pm line 66
> >         Bugzilla::Util::trick_taint('undef') called at tr_new_plan.cgi line 69
> > 
> > 
> 
> This is a Testopia issue. It has already been fixed on the 1.2.2 branch. I will
> try to release this weekend.


I am using bugzilla 2.22.7, installed testopia 1.2.2 on windows,and my 
DB is MySQL 5.0
Perl is ActivePerl-5.8.8.822-MSWin32-x86-280952
when i add a new plan ,it's getting the same error:

tr_new_plan.cgi: Undef to trick_taint at Bugzilla/Util.pm line 66, referer: http://localhost/tr_new_plan.cgi
tr_new_plan.cgi: \tBugzilla::Util::trick_taint('undef') called at D:/bugzilla/tr_new_plan.cgi line 64, referer: http://localhost/tr_new_plan.cgi

Is this version wrong ???
Possibly. 1.x branch is no longer supported however so I can't say for sure.
o?your means that the 1.2.2branch isn't fixed the issue  ??
which branch i could used ??    
I'm sorry i not good at English  ,^_^
The current version is 2.2 but you will need to upgrade Bugzilla to 3.2
Now i use the bugzilla-3.2.2 and testopia-2.2-BUGZILLA-3.2, it seem fine.
if i haven't mailserver,could i add a new account??
This is a question for the support lists. Please ask there and not in a fixed bug.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: