Closed Bug 377652 Opened 14 years ago Closed 14 years ago

Thunderbird Preferences (Composition) button cut off

Categories

(Mozilla Localizations :: de / German, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: marcia, Assigned: Thunderbird_Mail_DE)

Details

(Keywords: verified1.8.1.5)

Attachments

(3 files, 1 obsolete file)

Seen while testing the Thunderbird 2 release candidate. Several buttons on the Preferences | Composition pane are cut off on the mac. I will attach screenshots of both 10.3.9 PPC and Intel 10.4.9 - the cutoff is more noticeable on PPC than Intel.
Assignee: nobody → AlexIhrig
Marcia, what would be the best em size for the prefs window?

http://lxr.mozilla.org/l10n-mozilla1.8/source/de/mail/chrome/messenger/preferences/preferences.dtd#4

<!ENTITY prefWindow.styleMac   "width: 48em;">
Status: NEW → ASSIGNED
Not sure, but josh aas said he could advise you. You can find him on IRC in #developers as "josh".

(In reply to comment #2)
> Marcia, what would be the best em size for the prefs window?
> 
> http://lxr.mozilla.org/l10n-mozilla1.8/source/de/mail/chrome/messenger/preferences/preferences.dtd#4
> 
> <!ENTITY prefWindow.styleMac   "width: 48em;">
> 

adding josh to the bug.  I have now identified several other locales that have this issue, including da and no/NO. Need to share whatever relevant information with them as well.

(In reply to comment #3)
> Not sure, but josh aas said he could advise you. You can find him on IRC in
> #developers as "josh".
> 
> (In reply to comment #2)
> > Marcia, what would be the best em size for the prefs window?
> > 
> > http://lxr.mozilla.org/l10n-mozilla1.8/source/de/mail/chrome/messenger/preferences/preferences.dtd#4
> > 
> > <!ENTITY prefWindow.styleMac   "width: 48em;">
> > 
> 

Attached patch Fix prefs window width for OS X (obsolete) — Splinter Review
Attachment #264730 - Flags: approval1.8.1.5?
Bug fixed in trunk.
(In reply to comment #5)
> Created an attachment (id=264730) [details]
> Fix prefs window width for OS X
> 
I suggested this value, but now I read here that the effect is worse on 10.3 than on 10.4 - I can only test on 10.4.9PPC ATM, so a different value (52em?) might be more appropriate after all.
Marcia, could you test those two modified TB 2.0.0.0 builds on PPC 10.3.9 and tell us which one "looks better"?
Thanks a lot :)

51em:
http://thunderbird.dnsalias.net/downloads/beta/2.0.0.0_PrefTest/thunderbird-2.0.0.0.de.mac.test51em.dmg
52em:
http://thunderbird.dnsalias.net/downloads/beta/2.0.0.0_PrefTest/thunderbird-2.0.0.0.de.mac.test52em.dmg
Martin: The good news is that both builds seem to resolve the button cutoff issue on 10.3.9. However, I noticed that both builds seem to "shift" the tabs in Preferences | composition when you switch between the tabs. Build #52 shows less of a layout shift than Build #51, so if I had to choose between the two I would say go with #52 (assuming you can live with the slight layout issue).

(In reply to comment #8)
> Marcia, could you test those two modified TB 2.0.0.0 builds on PPC 10.3.9 and
> tell us which one "looks better"?
> Thanks a lot :)
> 
> 51em:
> http://thunderbird.dnsalias.net/downloads/beta/2.0.0.0_PrefTest/thunderbird-2.0.0.0.de.mac.test51em.dmg
> 52em:
> http://thunderbird.dnsalias.net/downloads/beta/2.0.0.0_PrefTest/thunderbird-2.0.0.0.de.mac.test52em.dmg
> 

Changed the width again from 51 to 52 em because of comments #7 - #9.
Attachment #264730 - Attachment is obsolete: true
Attachment #264865 - Flags: approval1.8.1.5?
Attachment #264730 - Flags: approval1.8.1.5?
Attachment #264865 - Flags: review?(mmx_bugzilla)
Comment on attachment 264865 [details] [diff] [review]
 Fix prefs window width for OS X

Looks good on OSX 10.4.9 using TB Version 2.0.0.4pre (20070517). Checked all tabs in all preference categories and nothing is cut off or appears out of place.
Cannot test on 10.3.x, but according to comment #9, it should be ok on that version, too.
Attachment #264865 - Flags: review?(mmx_bugzilla) → review+
Scott, is it possible to get this trivial fix into 1.8.1.4 or are we too late for?
Comment on attachment 264865 [details] [diff] [review]
 Fix prefs window width for OS X

[de] fix for tb dialog size fix approved. Please use the fixed1.8.1.5 and verified1.8.1.5 flags to track landing and testing.
Attachment #264865 - Flags: approval1.8.1.5? → approval1.8.1.5+
Whiteboard: [Checkin needed]
Patch checked in Mozilla_1.8_Branch.

Henrik, Martin or Marcia could you verify the fix?
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: fixed1.8.1.5
Resolution: --- → FIXED
Whiteboard: [Checkin needed]
Looks good with version 2.0.0.5pre (20070626)
You need to log in before you can comment on or make changes to this bug.