Closed
Bug 377674
Opened 17 years ago
Closed 17 years ago
wizard.xml cleanup
Categories
(Toolkit :: UI Widgets, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.56 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #261714 -
Flags: first-review?(mano)
Attachment #261714 -
Flags: first-review?(mano) → review?(mano)
Comment 1•17 years ago
|
||
Comment on attachment 261714 [details] [diff] [review] setters should return values, mark some properties readonly >Index: toolkit/content/widgets/wizard.xml >=================================================================== >RCS file: /cvsroot/mozilla/toolkit/content/widgets/wizard.xml,v >retrieving revision 1.32 >diff -u -p -8 -r1.32 wizard.xml >--- toolkit/content/widgets/wizard.xml 9 Sep 2006 08:18:59 -0000 1.32 >+++ toolkit/content/widgets/wizard.xml 16 Apr 2007 20:29:23 -0000 >@@ -30,21 +30,21 @@ > <xul:hbox class="wizard-buttons" anonid="Buttons" xbl:inherits="pagestep,firstpage,lastpage"/> > </content> > > <implementation> > <property name="title" onget="return document.title;" > onset="return document.title = val;"/> > > <property name="canAdvance" onget="return this._canAdvance;" >- onset="this._canAdvance=val; this._nextButton.disabled = !val;"/> >+ onset="this._canAdvance=val; this._nextButton.disabled = !val; return val;"/> hrm, maybe make that: this._nextButton.disabled = !val; return this._canAdvance = val;? > <property name="canRewind" onget="return this._canRewind;" >- onset="this._canRewind=val; this._backButton.disabled = !val;"/> >+ onset="this._canRewind=val; this._backButton.disabled = !val; return val;"/> > ditto. r=mano.
Attachment #261714 -
Flags: review?(mano) → review+
Assignee | ||
Comment 2•17 years ago
|
||
Test is part of bug 377253, but need a better test that tests the <wizard> api in general.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•