Closed Bug 377692 Opened 17 years ago Closed 17 years ago

numberbox.xml cleanup

Categories

(Toolkit :: UI Widgets, defect)

Product:
Toolkit
Component:
UI Widgets
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 3 obsolete files)

more like this
5.20 KB, patch
neil
: review+
Details | Diff | Splinter Review
bah, found another issue with disabled state when wraparound in set to true
5.95 KB, patch
neil
: review+
Details | Diff | Splinter Review 
- value should be returned as a string
- setters should return val
Blocks: 377253
Attached patch minor cleanup (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix string issues (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #261866 -
        Attachment is obsolete: true

        Attachment #261955 -
        Flags: first-review?(neil)

    
    

    
  
Comment on attachment 261955 [details] [diff] [review]
fix string issues

'Number("" + this.value)' looks ugly. Would you mind adding an accessor method for the numeric value?

        Attachment #261955 -
        Flags: first-review?(neil) → first-review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        more like this
        — 
          — Splinter Review
      

    


  

        Attachment #261955 -
        Attachment is obsolete: true

        Attachment #262022 -
        Flags: review?(neil)

    
  

        Attachment #262022 -
        Flags: review?(neil) → review+

    
    

    
  
Filed bug 378018 on getting a numberbox test
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  


  
rename this field, as the value can be a non-integer as well. Also fixes an issue when decimalPlaces is set to Infinity.

        Attachment #262154 -
        Flags: review?(neil)

    
  

        Attachment #262154 -
        Flags: review?(neil)

    
    

    
  


  
might need to rethink the disabled handling for spinbuttons a bit

        Attachment #262154 -
        Attachment is obsolete: true

        Attachment #262155 -
        Flags: review?(neil)

    
  

        Attachment #262155 -
        Flags: review?(neil) → review+

    
    

    
  
I have a testcase for this coming soon. Some functions in bug 371260 are needed.
Flags: in-testsuite?

    
    

    
  
Tests are bug 378018.
Flags: in-testsuite? → in-testsuite-

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: