377721 - add todo_is and todo_isnot to mochitest

Status: RESOLVED FIXED

Description

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Created attachment 261739 [details] [diff] [review]
patch

Having a todo version of mochitest's is function would make writing a bunch of the style system tests easier.  It's really useful to use "is", since then I get the incorrect result in the error message.  But I'm writing tests that iterate over a property database and have a bunch of known failures, so I want to be able to write things like this:

    var func = is;
    if (property in gKnownFails &&
        gKnownFails[property].indexOf(badval) != -1)
      func = todo_is;

    func(gDeclaration.getPropertyValue(property), "",
         "invalid value '" + badval + "' not accepted for '" + property +
         "' property");

(This is in the version of layout/style/test/test_property_syntax_errors.html that's in my tree.)

Thus, I'd like the following patch.

I'm not sure if we're doing anything to track changes we make to mochitest or to contribute them back -- if we are, what should I be doing?

Comment 1

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Note that these are copies of is and isnot with "ok" replaced by "todo".  I should probably say that in a comment above them...

Comment 2

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Checked in to trunk.