377744 - Optimize drag & drop and rezising of events/tasks

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Christian Jansen]

Optimize Drag & Drop and resizing of events:

For Day-, Multi-Day-, and Month Views
For events transitioning from first to second day.


Comment from #369689

Christian, just for clarification, with this patch in place it looks like this:

---------
|   | c |
|   | * |
| a | * |
| * | d |
| * |   |
| b |   |
---------

'a' is the start-grippy for the start of the event, 'b' is the end-grippy of
the transition from first day to second day (which can be dragged
upwards/downwards), 'c' is the start-grippy of the transition into the second
day (which can be dragged as well), 'd' is the end-grippy of the event. 'a' and
'd' can be dragged as usual. I'm talking here about the possibility to modify
'b' and 'c'. furthermore, e.g. 'b' can only be dragged within the first day,
and always results in the event to end on the first day, the user doesn't have
the possibility to drag sideways. what's your opinion on this?

----------

Comment 1

[Martin Schröder [:mschroeder]]

Bryan, what is your opinion about this?

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I think we should remove the grippys 'b' and 'c' and allow dragging events over multiple days. Lets see how easy this is to fix. If someone objects, please let me know.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Hmm not as easy as I thought. Decathlon, you've done some work on the dragboxes before, how much work would it be for you to fix this? Do you think you can get this done until the end of the month?

Comment 4

[Decathlon]

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> I think we should remove the grippys 'b' and 'c' and allow dragging events
> over multiple days. Lets see how easy this is to fix. If someone objects,
> please let me know.

Do you mean hide all the grippys except the first and the last and allow dragging these two in days different from those ones where they are (not allowed with the actual code)?

I've already seen it's not easy, at least for me, get into that code. I think I can do it , but I can't guarantee at all the deadline (also because of too many reviews at the moment ;-)).

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Decathlon from comment #4)
> (In reply to Philipp Kewisch [:Fallen] from comment #2)
> > I think we should remove the grippys 'b' and 'c' and allow dragging events
> > over multiple days. Lets see how easy this is to fix. If someone objects,
> > please let me know.
> 
> Do you mean hide all the grippys except the first and the last and allow
> dragging these two in days different from those ones where they are (not
> allowed with the actual code)?
Yes, this is what I meant.


> I've already seen it's not easy, at least for me, get into that code. I
> think I can do it , but I can't guarantee at all the deadline (also because
> of too many reviews at the moment ;-)).
The previous deadline is no longer important of course :-) The next possible merge date is December 20th and after that January 31st.

Comment 6

[Decathlon]

Attachment: patch-v1

I've deleted some things now useless, and a few things that seem useless even before.

I've made the shadow in a way that, when moving the start or the end of an event, it stops resizing when the mouse goes in a day (column) after the end date (or before the start date when moving the end date). The shadow resizes only when dragging on an date before the end date (or after the start date in the other case).
This behavior is different than before, but I think that in this case is more coherent with the new drag possibilities.

About the grip bars I have not found a different way than adding two compare() functions inside the relayout(). In total they will be two "compare" for every "chunk" of events shown in the view. If you have some suggestion in order to try to avoid them ...

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 579328 [details] [diff] [review]
patch-v1

Review of attachment 579328 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks fine, I think the compare() calls are ok. r=philipp

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

One thing I noticed (but was already not working before), you can now happily drag over multiple columns, but if you grab the end date grippy then you can't pull past the start date (i.e invert which grippy your are pulling and continue dragging into the past. It would be nice if you could take a look into that in a new bug.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 817576bcae20

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-aurora changeset 808401c2b2f2

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Sorry for the delay! I just rediscovered this bug :-)

Comment 12

[Decathlon]

Actually I'm working on your request in comment #8 :)
I wanted to attach a new patch here, but I haven't finished yet. 
I will open a new bug when I will have the solution.