Move bookmarks chrome to suite/

RESOLVED FIXED

Status

SeaMonkey
Bookmarks & History
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Just like we have already moved other chrome stuff from xpfe/ to suite/, we also need to move the bookmarks chrome from xpfe/components/bookmarks, likely to suite/browser/ (content)
(Assignee)

Updated

11 years ago
Assignee: nobody → kairo
I've just taken a look at xpfe/components/bookmarks - we're the only ones that build that directory (i.e. public, src and resources) completely (look through http://mxr.mozilla.org/seamonkey/find?string=build.mk if you really want to).

According to http://mxr.mozilla.org/seamonkey/source/xpfe/components/Makefile.in, Thunderbird, Sunbird and "Standalone" Composer use xpfe/components/bookmarks/public - though I don't think that any of them *need* to (mxr doesn't seem to think so either)

Therefore I suggest that if we're keeping the xpfe/components/bookmarks stuff for the time being, we just get the nod from those apps and move the whole of xpfe/components/bookmarks across to /suite, not just the chrome.
(Assignee)

Comment 2

11 years ago
We have C++ stuff all around xpfe tha needs to be moved some time, but I want to get the chrome part done ASAP. "source L10n" testing builds currently break with all kinds of bookmarks handling, this bug is the major reason why we can't let localizers go on and check in their work to CVS, so this should be done soon.

If someone else wants to work on moving all the C++ stuff from bookmarks and other xpfe dirs, that's very much appreciated though. 
(Assignee)

Comment 3

11 years ago
Created attachment 263672 [details] [diff] [review]
patch: add files in suite/ and remove xpfe resources from build

This patch adds the bookmarks files to the jar.mn files in suite/ and removes the resources/ dir from the build on the xpfe side.
cvs copies files is upcoming, the whole xpfe/components/bookmarks/resources/ directory can be cvs removed after this patch, I'll take r+sr on the patch and cvs copies as implicit r+sr for that removal.
Attachment #263672 - Flags: superreview?(neil)
Attachment #263672 - Flags: review?(neil)
(Assignee)

Comment 4

11 years ago
Created attachment 263673 [details]
cvs copies for bookmarks chrome

Here's the cvs copies to go along with above patch.
Attachment #263673 - Flags: superreview?(neil)
Attachment #263673 - Flags: review?(neil)

Updated

11 years ago
Attachment #263672 - Flags: superreview?(neil)
Attachment #263672 - Flags: superreview+
Attachment #263672 - Flags: review?(neil)
Attachment #263672 - Flags: review+

Updated

11 years ago
Attachment #263673 - Flags: superreview?(neil)
Attachment #263673 - Flags: superreview+
Attachment #263673 - Flags: review?(neil)
Attachment #263673 - Flags: review+
(Assignee)

Updated

11 years ago
Depends on: 379699
(Assignee)

Comment 5

11 years ago
patch landed, waiting a tinderbox cycle until doing the removal of old files and resolving this bug report.
(Assignee)

Comment 6

11 years ago
OK, checked everything in, old files cvs remoced, done.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(In reply to comment #0)
> likely to suite/browser/ (content)

For the record,
why did you change your mind from /browser/ to /common/ ?
(Assignee)

Comment 8

11 years ago
because it's been in chrome://communicator/ all the time - I don't agree that it's the best place, but also moving it around in chrome is too much work to do for me.
That's what I thought.

I filed
Bug 379835 – Move bookmarks chrome from /suite/common/ to /suite/browser/
You need to log in before you can comment on or make changes to this bug.