377825 - Users with editcomponents for a product don't see hyperlink to editproducts.cgi

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Kevin Benton]

Users with editcomponents turned on for a specific product don't get a link in template/en/default/global/useful-links.html.tmpl (near line 144).  I wonder if user.get_products_by_permission("editcomponents").size is working?

In my case, I just set up BZ, added a pair of groups Test1 and Test1Admin, then went into the default test product, added those two groups to the product, with Test1Admin having editcomponents capability, both having editbugs and confirmbugs.  After that, I created bztest as a user, adding it to both Test1 and Test1Admin.  Then, I impersonated the user and didn't see the Products hyperlink.  I followed up by logging out, then logging back in as the test user, and got the same results.  When I checked permissions for bztest, it showed it was a member of both Test1 and Test1Admin.

TestProduct shows group access controls with: Test1Admin: NA/NA, editcomponents, canconfirm, editbugs / Test1: NA/NA, canconfirm, editbugs

Comment 1

[Max Kanat-Alexander]

This is minor, not a blocker.

Comment 2

[Frédéric Buclin]

Attachment: patch for 3.0, v1

Trivial fix. CVS tip is not affected as admin.cgi manages this correctly.

Comment 3

[Kevin Benton]

Will review shortly.  Thanks LpSolit :-)

Comment 4

[Max Kanat-Alexander]

Comment on attachment 261974 [details] [diff] [review]
patch for 3.0, v1

I'm slightly concerned because there's no cache for get_products_by_permission. But this does look correct to me.

Comment 5

[Kevin Benton]

Comment on attachment 261974 [details] [diff] [review]
patch for 3.0, v1

Looks good to me.

Comment 6

[Frédéric Buclin]

Err... tip is not affected

Comment 7

[Frédéric Buclin]

Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v  <--  useful-links.html.tmpl
new revision: 1.56.2.1; previous revision: 1.56
done