377843 - dbus component would never build

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

The dbus component toolkit/system/dbus will never be built because
in toolkit-tiers.mk:

ifdef MOZ_ENABLE_DBUS
tier_toolkit_dirs    += toolkit/system/dbus
endif

but MOZ_ENABLE_DBUS is not in autoconf.mk but only a DEFINE which doesn't apply to a Makefile.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

short warning: the component doesn't build correctly as it seems

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch to link correctly

This fixes the build errors and it's just build config so adding it just here might make sense.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Fixed on trunk.

Checking in config/autoconf.mk.in;
/cvsroot/mozilla/config/autoconf.mk.in,v  <--  autoconf.mk.in
new revision: 3.422; previous revision: 3.421
done
Checking in toolkit/system/dbus/Makefile.in;
/cvsroot/mozilla/toolkit/system/dbus/Makefile.in,v  <--  Makefile.in
new revision: 1.3; previous revision: 1.2
done

Comment 5

[Robert Sayre]

This patch causes the Places linux trees to burn

http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaTest

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

The patch enables the component because it wasn't enabled by accident. So the initial issue is the dbus implementation.
I'll open another bug for that -> bug 377992