Closed Bug 377844 Opened 17 years ago Closed 17 years ago

Pop up safebrowsing EULA/select remoteLookups radio when a provider menuitem is selected

Categories

(Firefox :: Settings UI, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 alpha5

People

(Reporter: rflint, Assigned: rflint)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Bug 359107 made the provider menuitem enabled even when there's only one provider available. Seems like it'd make sense to select the remote lookup option if a user opens the menu and selects the only available provider.
Attachment #261923 - Flags: ui-review?(beltzner)
Attachment #261923 - Flags: review?(mano)
Attachment #261923 - Flags: ui-review?(beltzner) → ui-review+
Comment on attachment 261923 [details] [diff] [review]
Patch

I couldn't figure why you need to call onProviderChanged in both places
Attachment #261923 - Flags: review?(mano)
Comment on attachment 261923 [details] [diff] [review]
Patch

"oops", r=mano.
Attachment #261923 - Flags: review+
Whiteboard: [checkin needed]
mozilla/browser/components/preferences/security.js   1.11
mozilla/browser/components/preferences/security.xul  1.15
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: