Closed Bug 377846 Opened 13 years ago Closed 13 years ago

Quick Search on talkback-public not working (DB Error)

Categories

(mozilla.org :: Talkback Server & Webtool, task)

task
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: wildmyron, Assigned: jay)

References

()

Details

Most searches I try using the Quick Search time out and when I try to use the "Customize your search" fields I get a DB Error. E.g. the search from the URL field gives this:

DB Error processing query: SELECT * FROM (SELECT d.bbid from spiral.blackboxes_by_deployment d WHERE d.keyvalue LIKE ? ORDER BY d.bbid DESC) myresults WHERE rownum <=100 ORDER BY rownum
OS: Windows XP → All
Hardware: PC → All
Try also entering something on the top part of the page... it will make the query a bit quicker if you know what you're looking for.

The DB error is the result of some security fixes I made recently...see bug 323990.  The query performance took a hit, but we're actively looking for a better solution.  In the meantime, please specify as much info as possible in the query form and be patient as the query runs.  

The query you were trying to run was for a large data set (all Trunk crashes with given build id)... try adding a date range or specific string to look for... and let me know if you have any better luck.  Thanks!
Status: NEW → ASSIGNED
(In reply to comment #1)
> Try also entering something on the top part of the page... it will make the
> query a bit quicker if you know what you're looking for.

The reason I came across this is that sometimes Talkback doesn't seem to have symbols for a particular nightly, and that search is how I check to see if any reports have a sensible stack - before that buildid appears in the Crash Report.

> The DB error is the result of some security fixes I made recently...see bug
> 323990.  The query performance took a hit, but we're actively looking for a
> better solution.  In the meantime, please specify as much info as possible in
> the query form and be patient as the query runs.  

I don't have access to that bug to see what changed, but I seem to get the DB Error whenever I use "Customize your search" e.g:
[ stack signature: nsViewManager::Refresh, Product: FirefoxTrunk ]
I think that should be a relatively small set and it still gives the error. The error doesn't seem related to searches that might timeout because of query perf issues, in fact, I generally get that error pretty quick. (I have to admit I know close to zero about DB perf...)

> The query you were trying to run was for a large data set (all Trunk crashes
> with given build id)... try adding a date range or specific string to look
> for... and let me know if you have any better luck.  Thanks!

I didn't realize that was considered large for trunk builds, but I also tried searching for FirefoxTrunk, All, 20071612 which according to the Crash Analysis Report has less than 10 reports and that gave the same error.

I didn't have any better luck specifying a date range either.

The only search I found doesn't either timeout or give the error is searching for a specific ID. Unfortunately I don't know if that's due to the appallingly slow connection on my end.


Arie:  You are right, your query is very fast without my recent code changes.  My test query tool works fine with the old code:  http://talkback-public.mozilla.org/test/start.jsp?search=1&searchby=stacksig&match=contains&searchfor=&vendor=MozillaOrg&product=FirefoxTrunk&platform=Win32&buildid=2007041604&sdate=&stime=&edate=&etime=&sortby=bbid&rlimit=100

NOTE: That URL is for development/testing purposes only (/test instead of /search), and will not always work.

I will look into this tomorrow... hopefully I can fix this one regression so that you can continue to run your queries. :-)  
I think I fixed this particular issue.  I was not passing some of the bind variables for various query combinations.  I also cleaned up the results text and added the results limit and query time. 

Arie:  Please try now with your original query... things should work.  If you have time, try a few other complex queries with various fields empty... they should all work.

NOTE:  This bug is fixed, but I am still looking into the performance regression due to Oracle not liking my prepared statements changes (the db doesn't like using "LIKE" in prepared statements for some reason).  Some queries might take a while. :-(
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
(In reply to comment #3)
> I will look into this tomorrow... hopefully I can fix this one regression so
> that you can continue to run your queries. :-)  

Thank you! I do appreciate it :)

(In reply to comment #4)
> Arie:  Please try now with your original query... things should work.  If you
> have time, try a few other complex queries with various fields empty... they
> should all work.

Looks good, original queries work and tried different limits and sort criteria with no DB Error. I did get an Internal Server Error at one point during testing and now some queries seem to be timing out. I guess you're still working on it. Thanks again
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.