[FIX]Consider bailing out of ReconstructDocElementHierarchy if no root

RESOLVED INVALID

Status

()

Core
Layout
RESOLVED INVALID
11 years ago
11 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla1.9alpha4
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See bug 343293 comment 6:

But maybe we should also add an early return in
ReconstructDocElementHierarchy when there's no frame for the root content?
Created attachment 261925 [details] [diff] [review]
Proposed patch

Most of that is outdenting stuff...

Mats, I'd like you to take a look since you've been in this code recently.
Attachment #261925 - Flags: superreview?(dbaron)
Attachment #261925 - Flags: review?(mats.palmgren)

Comment 2

11 years ago
Comment on attachment 261925 [details] [diff] [review]
Proposed patch

>+      if (!docElementFrame) {
>+        return NS_ERROR_UNEXPECTED;
>+      }

I guess we want to know about it if that happens so could you
put in an assertion there as well...
r=mats
Attachment #261925 - Flags: review?(mats.palmgren) → review+
Comment on attachment 261925 [details] [diff] [review]
Proposed patch

sr=dbaron
Attachment #261925 - Flags: superreview?(dbaron) → superreview+
Checked in, with a NS_NOTREACHED before that early return.  Nothing here to test-suite, really.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
I backed this out, because this regressed bug 71191 (which is the one way we can _not_ have a frame for the root content), and because as a result it caused bug 379920.
Depends on: 379920
Resolution: FIXED → INVALID
You need to log in before you can comment on or make changes to this bug.