377850 - [FIX]Consider bailing out of ReconstructDocElementHierarchy if no root

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 343293 comment 6:

But maybe we should also add an early return in
ReconstructDocElementHierarchy when there's no frame for the root content?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Most of that is outdenting stuff...

Mats, I'd like you to take a look since you've been in this code recently.

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 261925 [details] [diff] [review]
Proposed patch

>+      if (!docElementFrame) {
>+        return NS_ERROR_UNEXPECTED;
>+      }

I guess we want to know about it if that happens so could you
put in an assertion there as well...
r=mats

Comment 3

[Boris Zbarsky [:bzbarsky]]

Will do.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 261925 [details] [diff] [review]
Proposed patch

sr=dbaron

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in, with a NS_NOTREACHED before that early return.  Nothing here to test-suite, really.

Comment 6

[Boris Zbarsky [:bzbarsky]]

I backed this out, because this regressed bug 71191 (which is the one way we can _not_ have a frame for the root content), and because as a result it caused bug 379920.