Range with no end attribute results in unusable control

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
11 years ago
a year ago

People

(Reporter: Steve Speicher, Assigned: aaronr)

Tracking

({fixed1.8.0.12, fixed1.8.1.4})

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070416 Minefield/3.0a4pre
Build Identifier: 

This was working at some point, see bug 331987

This fails W3C Test Suite cases 8.1.7.a and 8.1.7.c

Reproducible: Always
(Reporter)

Comment 1

11 years ago
Created attachment 261936 [details]
test case, 2 ranges with no ends
(Assignee)

Comment 2

11 years ago
problem was that we assumed slider's getXCoordFromValue shouldn't get or return NaN, but that just isn't feasible.  So with my patch we'll allow for the fact that this can happen (esp. during initialization) and I changed the functions that used the return value from getXCoordFromValue to be able to work ok if it did return NaN. 
Assignee: xforms → aaronr
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 3

11 years ago
Created attachment 262040 [details] [diff] [review]
patch
Attachment #262040 - Flags: review?(msterlin)
(Assignee)

Updated

11 years ago
Attachment #262040 - Flags: review?(surkov.alexander)

Comment 4

11 years ago
Comment on attachment 262040 [details] [diff] [review]
patch

fine
Attachment #262040 - Flags: review?(surkov.alexander) → review+

Comment 5

11 years ago
Looks good and works for all of the testcases I've tried. r=me

Comment 6

11 years ago
(In reply to comment #5)
> Looks good and works for all of the testcases I've tried. r=me
> 

Merle, it would be great if you'll set r+ additionally :)

Comment 7

11 years ago
(In reply to comment #6)
> (In reply to comment #5)
> > Looks good and works for all of the testcases I've tried. r=me
> > 
> Merle, it would be great if you'll set r+ additionally :)

It would be great if I were authorized to edit the bug so I could set the r+. :)

Comment 8

11 years ago
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Looks good and works for all of the testcases I've tried. r=me
> > > 
> > Merle, it would be great if you'll set r+ additionally :)
> 
> It would be great if I were authorized to edit the bug so I could set the r+.
> :)
> 

Oops :) Allan got rights for me and I don't know the procedure. I guess you should ask Aaron.
(Assignee)

Comment 9

11 years ago
Comment on attachment 262040 [details] [diff] [review]
patch

r+'ing for merle since he commented patch was ok
Attachment #262040 - Flags: review?(msterlin) → review+
(Assignee)

Comment 10

11 years ago
checked into trunk
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Assignee)

Comment 11

11 years ago
checked into 1.8 and 1.8.0 branches
Keywords: fixed1.8.0.12, fixed1.8.1.4
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.