377924 - download.js logic ignores pa-IN on the mac for thunderbird

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Scott MacGregor]

Nick noticed this.

This method:

function buildValidForPlatform(aLangID, aPlatform)
{
  var version = aLangID[aLangID.product];
  if ((aLangID.abCD == "gu-IN" ||
       (aLangID.abCD == "pa-IN" && version < "2.0.0.1")) &&
      (aPlatform == PLATFORM_MACOSX))
    return false;

  return true;
}

in download.js keeps us from listing pa-IN for Thunderbird 2.0.0.0 on all.html for the Mac even though we support it.

Since we no longer list 2.0.0.1 in the table for Firefox, maybe we could reduce the if statement logic to just:

  if (aLangID.abCD == "gu-IN" &&
      aPlatform == PLATFORM_MACOSX)

Comment 1

[Reed Loden [:reed]]

I can't do anything about this until tonight/tomorrow due to school. It'll just have to wait. Sorry.

Comment 2

[Scott MacGregor]

no worries.

Comment 3

[Reed Loden [:reed]]

(In reply to comment #0)
> Since we no longer list 2.0.0.1 in the table for Firefox, maybe we could reduce
> the if statement logic to just:
> 
>   if (aLangID.abCD == "gu-IN" &&
>       aPlatform == PLATFORM_MACOSX)

Oh, but we do! firefox/all-older.html...

A fix for this will be included in the new download.js mods I'm working on.

Comment 4

[Reed Loden [:reed]]

I checked in a fix for this to the trunk. Please confirm it is working as requested.

Comment 5

[Scott MacGregor]

I verified that:

https://en.www.trunk.stage.mozilla.com/en/thunderbird/all.html

contains the right link for gu-IN on the Mac.

Thanks Reed!

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

reed, the 2.0 page looks good but the Thunderbird 1.5 one regressed:
  https://en.www.trunk.stage.mozilla.com/en/thunderbird/all-older.html
pa-IN should not have a mac version there. Firefox looks fine with a spot check.

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> reed, the 2.0 page looks good but the Thunderbird 1.5 one regressed:
>   https://en.www.trunk.stage.mozilla.com/en/thunderbird/all-older.html
> pa-IN should not have a mac version there. Firefox looks fine with a spot
> check.

Sending        js/download.js
Transmitting file data .
Committed revision 3700.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #7)
> Sending        js/download.js
> Transmitting file data .
> Committed revision 3700.

This incarnation looks good.

Comment 9

[Reed Loden [:reed]]

Tagged for production in r3717.