Closed
Bug 377924
Opened 18 years ago
Closed 18 years ago
download.js logic ignores pa-IN on the mac for thunderbird
Categories
(www.mozilla.org :: General, defect)
www.mozilla.org
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mscott, Assigned: reed)
Details
Nick noticed this.
This method:
function buildValidForPlatform(aLangID, aPlatform)
{
var version = aLangID[aLangID.product];
if ((aLangID.abCD == "gu-IN" ||
(aLangID.abCD == "pa-IN" && version < "2.0.0.1")) &&
(aPlatform == PLATFORM_MACOSX))
return false;
return true;
}
in download.js keeps us from listing pa-IN for Thunderbird 2.0.0.0 on all.html for the Mac even though we support it.
Since we no longer list 2.0.0.1 in the table for Firefox, maybe we could reduce the if statement logic to just:
if (aLangID.abCD == "gu-IN" &&
aPlatform == PLATFORM_MACOSX)
Assignee | ||
Comment 1•18 years ago
|
||
I can't do anything about this until tonight/tomorrow due to school. It'll just have to wait. Sorry.
OS: Windows XP → All
Hardware: PC → All
Reporter | ||
Comment 2•18 years ago
|
||
no worries.
Assignee | ||
Comment 3•18 years ago
|
||
(In reply to comment #0)
> Since we no longer list 2.0.0.1 in the table for Firefox, maybe we could reduce
> the if statement logic to just:
>
> if (aLangID.abCD == "gu-IN" &&
> aPlatform == PLATFORM_MACOSX)
Oh, but we do! firefox/all-older.html...
A fix for this will be included in the new download.js mods I'm working on.
Assignee | ||
Comment 4•18 years ago
|
||
I checked in a fix for this to the trunk. Please confirm it is working as requested.
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•18 years ago
|
||
I verified that:
https://en.www.trunk.stage.mozilla.com/en/thunderbird/all.html
contains the right link for gu-IN on the Mac.
Thanks Reed!
Comment 6•18 years ago
|
||
reed, the 2.0 page looks good but the Thunderbird 1.5 one regressed:
https://en.www.trunk.stage.mozilla.com/en/thunderbird/all-older.html
pa-IN should not have a mac version there. Firefox looks fine with a spot check.
Assignee | ||
Comment 7•18 years ago
|
||
(In reply to comment #6)
> reed, the 2.0 page looks good but the Thunderbird 1.5 one regressed:
> https://en.www.trunk.stage.mozilla.com/en/thunderbird/all-older.html
> pa-IN should not have a mac version there. Firefox looks fine with a spot
> check.
Sending js/download.js
Transmitting file data .
Committed revision 3700.
Comment 8•18 years ago
|
||
(In reply to comment #7)
> Sending js/download.js
> Transmitting file data .
> Committed revision 3700.
This incarnation looks good.
Assignee | ||
Comment 9•18 years ago
|
||
Tagged for production in r3717.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Updated•13 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•