377955 - download.js and products/download.html should be able to use different download URLs

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Scott MacGregor]

http://www.mozilla.com/en-US/thunderbird/all.html

Thunderbird 2 is configured to use bouncer 2 at download2.mozilla.org.

however the download.js script shared by Thunderbird and Firefox is hardcoded to use download.mozilla.org.

Reed/morgamic/preed/mrz and others are brain storming on IRC about how to fix this in the short term and in the long term.

Comment 1

[Reed Loden [:reed]]

Looks like preed / morgamic are going to put the info in bouncer1, but I wrote this mod_rewrite magic that would work:
RewriteEngine on
RewriteCond %{QUERY_STRING} ^product=thunderbird-2\.0\.0\.0
RewriteRule ^(.*)$ http://download2.mozilla.org/

Comment 2

[Scott MacGregor]

bouncer 1 links look they are starting to work, I'm able to start downloading builds on: http://www.mozilla.com/en-US/thunderbird/all.html.

Comment 3

[Reed Loden [:reed]]

Do we want to leave it with bouncer1 for now or try using the rewrite?

Comment 4

[J. Paul Reed [:preed]]

Let's fix the website to point Thunderbird only to bouncer2.

After pushing it to staging, let us know, and we'll run a download checker against Thunderbird and Firefox (on staging), and then we can push to prod.

Comment 5

[Scott MacGregor]

I'll take a look at changing download.js to make this work while leaving firefox downloads alone. I'll submit my ideas to rhelmer and reed for review tomorrow to see what they think.

Comment 6

[Reed Loden [:reed]]

download.js isn't the only thing that needs to be changed. products/download.html will need to be modified, too.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

do you need that we change thunderbird download links on mozilla europe to point to download2.mozilla.org instead of download.mozilla.org ?

Comment 8

[Michael Morgan [:morgamic]]

No, for now we will use bouncer1 until we figure out the safest way to redirect tb to bouncer2.

Comment 9

[Michael Morgan [:morgamic]]

This particular issue was fixed around 245pm pst.  Please reopen if there are still issues.  :)

Comment 10

[Scott MacGregor]

Attachment: download.js and download.html changes to make thunderbird 2 use bouncer2

Here's my first cut at modifying download.js and download.html to route thunderbird 2.0.0.0 (and higher) downloads through bouncer 2. Everything else (including Firefox) continues to use bouncer 1.

This change is on the trunk.stage.mozilla.com so reviewers and testers can see how it behaves. 

Here are the tests I did. Note you need to test with both firefox and IE7 because we write out different download urls (firefox goes through download.html). You can verify the download url used by download.html by looking at the url linked to in the "use this link" text on that page.

Testing Thunderbird downloads using Firefox:

https://en.www.trunk.stage.mozilla.com/en/thunderbird/all.html  - Each 2.0.0.0 product link should take you to download.html which in turn loads from download2.mozilla.org. The 1.5.0.x links on this page should go through download.html which should load from download.mozilla.org.

https://en.www.trunk.stage.mozilla.com/en/thunderbird/all-older.html - every product link on this page should go through download.html which should laod from download.mozilla.org. 

https://en.www.trunk.stage.mozilla.com/en/thunderbird - The download now button should take you through download.html using download2.mozilla.org

Thunderbird using IE 7:

https://en.www.trunk.stage.mozilla.com/en/thunderbird/all.html  - Each 2.0.0.0 product link should use download2.mozilla.org if you hover over the link on this page. The 1.5.0.x links on this page should use download.mozilla.org

https://en.www.trunk.stage.mozilla.com/en/thunderbird/all-older.html - every download link on this page should use download.mozilla.org

https://en.www.trunk.stage.mozilla.com/en/thunderbird - The download now button should use download2.mozilla.org

Downloading Firefox using Firefox:

https://en.www.trunk.stage.mozilla.com/en/firefox/all.html  - All download links on this page should take you to download.html which in turn loads from download.mozilla.org. 

https://en.www.trunk.stage.mozilla.com/en/firefox/all-older.html - every product link on this page should go through download.html which should laod from download.mozilla.org. 

https://en.www.trunk.stage.mozilla.com/en/firefox - The download now button should take you through download.html using download.mozilla.org

Downloading Firefox using IE 7:

https://en.www.trunk.stage.mozilla.com/en/firefox/all.html  - Every download link should use download.mozilla.org if you hover over the link on this page. 

https://en.www.trunk.stage.mozilla.com/en/firefox/all-older.html - every download link on this page should use download.mozilla.org

https://en.www.trunk.stage.mozilla.com/en/firefox- The download now button should go through download.mozilla.org

Comment 11

[Scott MacGregor]

Comment on attachment 262176 [details] [diff] [review]
download.js and download.html changes to make thunderbird 2 use bouncer2

What do you guys think of this approach?

Comment 12

[Scott MacGregor]

Comment on attachment 262176 [details] [diff] [review]
download.js and download.html changes to make thunderbird 2 use bouncer2

Rob might have some ideas on this too.

Comment 13

[Reed Loden [:reed]]

Comment on attachment 262176 [details] [diff] [review]
download.js and download.html changes to make thunderbird 2 use bouncer2

I'm rewriting a lot of this. I think I can just make products/download.html pull the info from download.js instead of keeping two copies of the same information.

Comment 14

[Reed Loden [:reed]]

Sending        trunk/en-US/products/download.html
Sending        trunk/js/download.js
Transmitting file data ..
Committed revision 3487.

Comment 15

[Michael Morgan [:morgamic]]

Can we test this a bit and get this up this week?  We'd like to get stuff pointing at bouncer2 so we can do a full migration next week or so.

Comment 16

[Nick Thomas [:nthomas] (UTC+12)]

It's a minor issue but bug 377924 comment #6 is still true in the new logic.

Comment 17

[Reed Loden [:reed]]

Tagged for production in r3717.