Closed Bug 377958 Opened 17 years ago Closed 17 years ago

Range: JS error - document.commandDispatcher has no properties

Categories

(Core Graveyard :: XForms, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 329394

People

(Reporter: msterlin, Assigned: msterlin)

Details

Attachments

(2 files)

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; formsPlayer 1.4; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070412 Minefield/3.0a4pre

The range widgets that use spinbuttons/numberboxes show a Javascript error 'document.commandDispatcher has no properties' on the 1.8 branch. The problem does NOT occur on the trunk.

The problem is that the toolkit's textbox (toolkit\content\widgets\textbox.xml) on the branch does not contain the fix from bug329394 which changes the textbox focus handler to use event.originalTarget instead of document.commandDispatcher.

We can work around the problem for the branches by overriding the textbox's focus handler and will apply the patch to both the trunk and branches to keep the code common.




Reproducible: Always
I have asked for approval to put the patch for bug 329394 on the branches.  If that approval doesn't come through, we'll use Merle's approach.
Assignee: xforms → msterlin
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → ASSIGNED
Range testcase that uses spinbuttons/numberboxes for the range. The values of the numberboxes will not update correctly and the console window from which firefox was launched will show 'JS error: document.commandDispatcher has no properties'.
Attached patch patchSplinter Review
Override the textbox focus handler in numberbox. The numberbox focus handler now looks like the textbox focus handler from the patch for 329394. This work around will no longer be necessary if we can get 329394 applied to the branches.
Attachment #262053 - Flags: review?(aaronr)
Attachment #262053 - Flags: review?(aaronr)
Duping this bug to 329394 because the patch for 329394 has been checked in to  the 1.8 branch and there is no longer a need for us to work around the problem in the XForms code.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: