Created attachment 262055 [details] [diff] [review] Change test strings for passing cases The following lines show up in results.html where all tests pass : Certutil failed in a nonexisting dir 255 Passed Dbtest readonly failed in a nonexisting dir 46 Passed Tstclnt failed in an empty dir 1 Passed Dbtest readonly failed in an empty dir 46 Passed Certutil failed in an empty dir 255 Passed Dbtest r/w failed in an readonly dir 46 Passed Certutil failed in an readonly dir 255 Passed I think it's confusing to have the word "failed" show up there, since that's the same word present in the "Result" column when a test fails. I know the case is different, but I have been finding this confusing for years. So, I propose to change it from "failed" to "didn't work" in the test name for those 7 cases.
Attachment #262055 - Flags: review?(nelson)
Comment on attachment 262055 [details] [diff] [review] Change test strings for passing cases r=nelson for trunk. I'm concerned about the use of the apostrophe in the strings, but if they break anything, that will be easy to fix.
Attachment #262055 - Flags: review?(nelson) → review+
Thanks for the quick review, Nelson ! I fixed this on the trunk. Checking in dbtests.sh; /cvsroot/mozilla/security/nss/tests/dbtests/dbtests.sh,v <-- dbtests.sh new revision: 1.13; previous revision: 1.12 done
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Nelson, We already have many apostrophes in test names in results.html, so I think we will be OK. Also, I ran all.sh with my patch before submitting it and there were no issues.
You need to log in before you can comment on or make changes to this bug.