377973 - Pref panel should be ridin' spinnas

Status: RESOLVED DUPLICATE of bug 394426

(Firefox :: Settings UI, defect)

Description

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Sorry, I had to ;)

The numeric-only inputs could use a little type=number and <spinbuttons> love. The history option increments by one and the cache by two.

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: The result

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Neil has a nearly identical patch in bug 245421. Why do you need the style rules?

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

(In reply to comment #2)
> Why do you need the style rules?
> 

Without the styling, adding the spinbuttons makes the textbox 4px taller (on Windows at least with default font size/DPI) which leaves a lot of space above and below the value and throws off the vertical spacing between the browsing and form history checkboxes.
The padding between the buttons and input was requested by beltzner.

Comment 4

[Steffen Wilberg]

If we need to improve spinbuttons' appearance in general, you should tweak spinbuttons.css instead.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 262058 [details] [diff] [review]
Patch

I'm fine with making these spinners from an interaction perspective. Please make sure that the styling is being done in the right place, etc, as per other comments here.