377995 - Move nsCategoryCache to the XPCOM Glue

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

biesi's helper class is pretty handy and I'd like to use it from external linkage. This patch moves it to the glue.

I had to add nsObserverList.h to the list of exported headers... Not sure if there are any rules/guidelines on what should or shouldn't be exported.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: String changes for nsCategoryCache.cpp

Note that I had to make some additional changes to make the class work with the external string API.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 262092 [details] [diff] [review]
Patch, v1

biesi, since this is your code I'd like your thoughts too.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

We could do a CVS copy, too, but it's still on the first revision. Thoughts?

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Why did you have to add nsObserverList.h? where's that included from?

can we add EqualsASCII to nsStringAPI?

if you don't do a cvs copy please mention the original bug# in your checkin comment

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #4)
> Why did you have to add nsObserverList.h? where's that included from?

nsCategoryCache.cpp includes nsObserverService.h which then includes nsObserverList.h.

> can we add EqualsASCII to nsStringAPI?

There are a lot of methods I'd like to add to the external string API... 

> if you don't do a cvs copy please mention the original bug# in your checkin
> comment

Sure.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2

No more nsObserverList gymnastics, removed the observer service contractID from nsObserverService.h.

Comment 7

[Benjamin Smedberg]

Comment on attachment 262269 [details] [diff] [review]
Patch, v2

>Index: xpcom/glue/nsCategoryCache.h

>+class NS_COM nsCategoryObserver : public nsIObserver {

you want NS_COM_GLUE

r=me with that change

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #7)

Fixed with that change.