Closed
Bug 377995
Opened 17 years ago
Closed 17 years ago
Move nsCategoryCache to the XPCOM Glue
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
Details
Attachments
(1 file, 2 obsolete files)
24.88 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
biesi's helper class is pretty handy and I'd like to use it from external linkage. This patch moves it to the glue. I had to add nsObserverList.h to the list of exported headers... Not sure if there are any rules/guidelines on what should or shouldn't be exported.
Attachment #262092 -
Flags: review?(benjamin)
Assignee | ||
Comment 1•17 years ago
|
||
Note that I had to make some additional changes to make the class work with the external string API.
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 262092 [details] [diff] [review] Patch, v1 biesi, since this is your code I'd like your thoughts too.
Attachment #262092 -
Flags: review?(cbiesinger)
Assignee | ||
Comment 3•17 years ago
|
||
We could do a CVS copy, too, but it's still on the first revision. Thoughts?
Comment 4•17 years ago
|
||
Why did you have to add nsObserverList.h? where's that included from? can we add EqualsASCII to nsStringAPI? if you don't do a cvs copy please mention the original bug# in your checkin comment
Assignee | ||
Comment 5•17 years ago
|
||
(In reply to comment #4) > Why did you have to add nsObserverList.h? where's that included from? nsCategoryCache.cpp includes nsObserverService.h which then includes nsObserverList.h. > can we add EqualsASCII to nsStringAPI? There are a lot of methods I'd like to add to the external string API... > if you don't do a cvs copy please mention the original bug# in your checkin > comment Sure.
Assignee | ||
Comment 6•17 years ago
|
||
No more nsObserverList gymnastics, removed the observer service contractID from nsObserverService.h.
Attachment #262092 -
Attachment is obsolete: true
Attachment #262093 -
Attachment is obsolete: true
Attachment #262269 -
Flags: review?(benjamin)
Attachment #262093 -
Flags: review?(benjamin)
Attachment #262092 -
Flags: review?(cbiesinger)
Attachment #262092 -
Flags: review?(benjamin)
Comment 7•17 years ago
|
||
Comment on attachment 262269 [details] [diff] [review] Patch, v2 >Index: xpcom/glue/nsCategoryCache.h >+class NS_COM nsCategoryObserver : public nsIObserver { you want NS_COM_GLUE r=me with that change
Attachment #262269 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 8•17 years ago
|
||
(In reply to comment #7) Fixed with that change.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•