Move nsCategoryCache to the XPCOM Glue

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Created attachment 262092 [details] [diff] [review]
Patch, v1

biesi's helper class is pretty handy and I'd like to use it from external linkage. This patch moves it to the glue.

I had to add nsObserverList.h to the list of exported headers... Not sure if there are any rules/guidelines on what should or shouldn't be exported.
Attachment #262092 - Flags: review?(benjamin)
Created attachment 262093 [details] [diff] [review]
String changes for nsCategoryCache.cpp

Note that I had to make some additional changes to make the class work with the external string API.
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #262093 - Flags: review?(benjamin)
Comment on attachment 262092 [details] [diff] [review]
Patch, v1

biesi, since this is your code I'd like your thoughts too.
Attachment #262092 - Flags: review?(cbiesinger)
We could do a CVS copy, too, but it's still on the first revision. Thoughts?
Why did you have to add nsObserverList.h? where's that included from?

can we add EqualsASCII to nsStringAPI?

if you don't do a cvs copy please mention the original bug# in your checkin comment
(In reply to comment #4)
> Why did you have to add nsObserverList.h? where's that included from?

nsCategoryCache.cpp includes nsObserverService.h which then includes nsObserverList.h.

> can we add EqualsASCII to nsStringAPI?

There are a lot of methods I'd like to add to the external string API... 

> if you don't do a cvs copy please mention the original bug# in your checkin
> comment

Sure.

Created attachment 262269 [details] [diff] [review]
Patch, v2

No more nsObserverList gymnastics, removed the observer service contractID from nsObserverService.h.
Attachment #262092 - Attachment is obsolete: true
Attachment #262093 - Attachment is obsolete: true
Attachment #262269 - Flags: review?(benjamin)
Attachment #262093 - Flags: review?(benjamin)
Attachment #262092 - Flags: review?(cbiesinger)
Attachment #262092 - Flags: review?(benjamin)

Comment 7

11 years ago
Comment on attachment 262269 [details] [diff] [review]
Patch, v2

>Index: xpcom/glue/nsCategoryCache.h

>+class NS_COM nsCategoryObserver : public nsIObserver {

you want NS_COM_GLUE

r=me with that change
Attachment #262269 - Flags: review?(benjamin) → review+
(In reply to comment #7)

Fixed with that change.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.