378043 - pyxpcom: Add the NS_XPCOM_CURRENT_PROCESS_DIR to sys.path

Status: RESOLVED FIXED

(Other Applications Graveyard :: PyXPCOM, defect)

Description

[Klaus Nowikow]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.5 (like Gecko) (Kubuntu)
Build Identifier: 1.9a4pre

As there is already stated in a comment in extensions/python/xpcom/src/dllman.cpp, the application path should also be added to sys.path -- at least when building xulrunner.
Otherwise one has a hard time importing local python modules that are shipped with the application.

Reproducible: Always

Comment 1

[Klaus Nowikow]

Attachment: A patch that works for me on Linux

Comment 2

[Klaus Nowikow]

Come to think of it, maybe adding NS_XPCOM_COMPONENT_DIR instead of NS_XPCOM_CURRENT_PROCESS_DIR would even be better

Comment 3

[Benjamin Smedberg]

I can't imagine that it's a good idea to put python modules directly in the appdir or the components dir. Instead, we should be using appdir/python-lib, and all extensiondirs/python-lib.

Comment 4

[Klaus Nowikow]

That would be ok for me. Actually, the patch adds appdir/python. I don't know how to automatically add the extensiondirs, though.

Comment 5

[Benjamin Smedberg]

Take the list from http://lxr.mozilla.org/mozilla/source/toolkit/xre/nsXULAppAPI.h#173

See, e.g. http://lxr.mozilla.org/mozilla/source/browser/components/dirprovider/nsBrowserDirectoryProvider.cpp#236 which does something similar to look in extensiondirs/searchplugins.

Comment 6

[Klaus Nowikow]

Attachment: New version, adding {app}/python-lib and all {extension_dirs}/python-lib to sys.path

Thank you for the help.

This patch now adds {app}/python-lib and (hopefully) all {extension-dirs}/python-lib.
I tested it briefly, and it seems to work on Linux, at least for (app). I haven't tested the extension dirs yet.

Comment 7

[Todd Whiteman]

Expired - Pyxpcom has added "bin/python" to the Python sys.path for a long time now, so this is supported.