Closed
Bug 378081
Opened 18 years ago
Closed 17 years ago
Followup to bug 367055, assign key values to BrowserWindow.nib and remove hack
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: nick.kreeger, Assigned: stuart.morgan+bugzilla)
References
Details
(Keywords: fixed1.8.1.8)
Attachments
(2 files)
|
1.39 KB,
patch
|
nick.kreeger
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
|
25.00 KB,
application/octet-stream
|
Details |
In order to not change any nibs close to release time, we just removed the 0 index menu item in BWC for unsafe URI links.
This needs to be changed so that the "open link in.." menu items are removed using their defined values in BWC.
This really should be on the 1.6 list (and be done before 1l0n freeze) so we don't leave the hack in any longer than needed.
Summary: Followup to bug 367055, assign key values to BrowserWindow.nib → Followup to bug 367055, assign key values to BrowserWindow.nib and remove hack
Target Milestone: --- → Camino1.6
Version: 1.8 Branch → unspecified
|
Assignee | |
Comment 2•17 years ago
|
||
Assignee: nobody → stuart.morgan
Status: NEW → ASSIGNED
Attachment #277301 -
Flags: review?(nick.kreeger)
|
|
Assignee | |
Comment 3•17 years ago
|
||
|
Reporter | |
Comment 4•17 years ago
|
||
Comment on attachment 277301 [details] [diff] [review]
fix
- [result removeItemAtIndex:0]; // remove separator
+ NSMenuItem* frameItem;
+ while ((frameItem = [result itemWithTag:kLinkOpeningItemsTag]) != nil)
+ [result removeItem:frameItem];
Looks good to me. Do we still want to remove the separator?
Attachment #277301 -
Flags: review?(nick.kreeger) → review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Comment on attachment 277301 [details] [diff] [review]
fix
Yep, I tagged the separator as well.
Attachment #277301 -
Flags: superreview?(mikepinkerton)
|
||
Comment 6•17 years ago
|
||
Comment on attachment 277301 [details] [diff] [review]
fix
sr=pink
Attachment #277301 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
Assignee | |
Comment 7•17 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
You need to log in
before you can comment on or make changes to this bug.
Description
•