Closed
Bug 378129
Opened 17 years ago
Closed 17 years ago
Consistently pass the right frame to InvalidateInternal
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: sharparrow1, Assigned: sharparrow1)
Details
Attachments
(1 file)
|
2.56 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
nsBlockFrame::InvalidateInternal and nsListControlFrame::InvalidateInternal pass their input aForChild to their parent. This is wrong; they should be passing this. (Fixing this could be a perf improvement because currently this screws up the check in nsGfxScrollFrameInner::InvalidateInternal.) Patch coming up.
|
Assignee | |
Comment 1•17 years ago
|
||
Pretty straightforward, unless I'm misinterpreting the doc comments for InvalidateInternal. All the other implementations of InvalidateInternal get this right.
Attachment #262212 -
Flags: review?(roc)
Comment on attachment 262212 [details] [diff] [review] Patch good catch
Attachment #262212 -
Flags: superreview+
Attachment #262212 -
Flags: review?(roc)
Attachment #262212 -
Flags: review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite?
|
|
Assignee | |
Comment 4•17 years ago
|
||
No correctness issues here; the only place that depends on the passed-in frame uses it for a perf optimization.
Flags: in-testsuite? → in-testsuite-
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•