378157 - Numberboxes are a bit too tall on Windows

Status: RESOLVED WONTFIX

(Toolkit :: UI Widgets, defect)

Description

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Remove the min-height from descendant spinbutton buttons

On Windows (haven't seen the same behavior on Mac/GNOME) numberboxes with spinbuttons enabled are about 4px taller than their regular textbox counterparts.

Comment 1

[Neil Deakin]

Comment on attachment 262223 [details] [diff] [review]
Remove the min-height from descendant spinbutton buttons

Won't this make the numberbox too small on non-XP (or the XP classic theme is used) or native theming is disabled?

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 262223 [details] [diff] [review]
Remove the min-height from descendant spinbutton buttons

Ah, you're right - I'll look for another solution.

Comment 3

[Nickolay_Ponomarev]

ping? This problem makes the otherwise shiny prefs window look slightly unpolished.

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

nominating since those numberboxes simply don't fit  ;)

Comment 6

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to comment #2)
Ryan, do you work on this in near future?

Comment 7

[:Gijs (he/him)]

Not going to fix this anymore, I think.