378275 - Camino should not remember obviously wrong window sizes or positions

Status: RESOLVED WONTFIX

(Camino Graveyard :: General, defect)

Description

[Chris Lawson (gone)]

From feedback:

"I've been very happy using Camino but now whenever I open a new  
window it automatically opens in a small box in the corner of the  
screen.  How can I change that setting so when I open a new Camino  
window it opens in a different area of my screen and bigger?"

I suspect what's happened here is that somehow Camino is remembering a popup window as the default window dimensions and position.

We should ensure that our window positioning code does not remember windows sized smaller than the dimensions to which a window can be manually resized, nor windows positioned with their upper-left corner outside some reasonable "normal" bounds of the main screen or any secondary screen. (Windows positioned in the extreme bottom-right corner, for instance, should probably not be remembered regardless of dimensions.)

Right now, I think all we ignore is windows without a certain level of chrome (see also bug 331066), although there was a similar bug way back in the day that Simon fixed regarding a sensible default window size/position (bug 307837).

Comment 1

[Mike Pinkerton (not reading bugmail)]

seems reasonable to me.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'll take that as a NEW ;)

Comment 3

[Chris Lawson (gone)]

If anyone can think of how such a window could be created and circumvent our current means of preventing this problem:

http://lxr.mozilla.org/mozilla/source/camino/src/browser/BrowserWrapper.mm#904

I'm all ears.

Comment 4

[Chris Lawson (gone)]

So that what just happened to me doesn't happen again in the future, comment 3 refers to the |createBrowserWindow:| method, which is now here:

http://lxr.mozilla.org/mozilla/source/camino/src/browser/BrowserWrapper.mm#1011

Comment 5

[Chris Lawson (gone)]

Attachment: testcase to try

This is a testcase I put together around the time I filed the bug, although I was never able to reproduce the behaviour from feedback.

Comment 6

[Gordon P. Hemsley [:GPHemsley]]

This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]