378412 - Adding a "Gmail" account that already was entered manually results in invisible duplicate

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Thomas]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; MathPlayer 2.0; .NET CLR 2.0.50727; .NET CLR 1.1.4322; .NET CLR 3.0.04506.30; InfoPath.2)
Build Identifier: version 2.0.0.0 (20070326)

Adding a "Gmail" account that already was entered manually results in invisible duplicate.

The account exists twice but you can only see one because it uses the same server address.

Reproducible: Didn't try

Steps to Reproduce:
1. Manually create pop account for gmail
2. Create gmail account for same user.
Actual Results:  
You have 2 email accounts but can only see one. All messages are downloaded twice.

Expected Results:  
Not allowed the creation of the account

You can use the config editor to change the server address so you can then delete it in the account manager.

Comment 1

[Carsten Book [:Tomcat]]

Maybe the 2. account is using the global inbox, so that this 2nd account is hidden. You can change this setting under "Tools -> Account Settings -> Server Settings" and click on the "Advanced" button. A dialog box will then pop open.

Comment 2

[Thomas]

The 1st account was using Local Folders, 2nd was not.
Until you changed the server address it was like #2 didn't exist, except it still pushed its msg's to Local Folders.

You couldn't see it in any menu, but mail just "appeared."

Clarification:
#1: Created with POP wizard.
#2: Created with GMAIL wizard.

The gmail wizard doesn't have the checks for duplicate accounts when you enter the server address becuase it never shows you that step, it skips to the end.

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to comment #2)
>
> Clarification:
> #1: Created with POP wizard.
> #2: Created with GMAIL wizard.
> 
> The gmail wizard doesn't have the checks for duplicate accounts when you enter
> the server address becuase it never shows you that step, it skips to the end.

I'm not familiar with gmail wizard.
similarity to bug 303542?

Comment 4

[Wayne Mery (:wsmwk)]

(maybe not. I was thinking of bug 409839 - but that's about folders, not accounts)

Comment 5

[Thomas]

Sounds similar to bug 303542, different way of getting there although they could be the result of the same malformed verification check. Also similar to bug 226303.

I have since stopped using thunderbird but will try to get it running and see if i can reproduce this bug and if not bug 303542.

Comment 6

[Thomas]

Still creates an invisible account that doesn't do anything until you delete the first (pop wizard) account.

Using the gmail wizard and then the pop wizard will not let you make the duplicate.

Comment 7

[Thomas]

Reproducible: Always

Steps to Reproduce:
1. Use pop email wizard to create email account
2. Use gmail wizard to create same email account

Actual Results:  
You have 2 email accounts but can only see one.

Expected Results:  
Not allowed the creation of the duplicate account.

Workaround:
Setting one of the mail.server.server#.hostname's to be different from pop.gmail.com

Comment 8

[WADA:World Anti-bad-Duping Agency]

Basically DUP of Bug 303542. But there can be other problems in "Gmail POP" account wizard in addition to problem of Bug 303542. So setting dependency instead of DUPing.

Comment 9

[Thomas]

I think they stem from different causes. I think Bug 378412 is the lack of a check in the wizard and Bug 303542 is a lack of changing settings compounded by an incomplete check.

Comment 10

[Magnus Melin [:mkmelin]]

I'll take this for now (i know it happens), but chances are the new account setup will take care of it.

Comment 11

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 12

[David :Bienvenu]

Magnus, does the user get any feedback here as to why they can't advance? I guess it's too late for beta 1 to add a string but maybe we could use an existing message about an account already existing?

Comment 13

[Magnus Melin [:mkmelin]]

No, there's no feedback in form of a dialog. It just disables the Next button, the same way like it does for invalid e-mail addresses or when no e-mail is added.

Comment 14

[Magnus Melin [:mkmelin]]

And actually the alerts we used to have for such purposes were converted to this style in bug 146392. I tend to agree it's better, it's pretty obvious what happens, and if you enter/remove another character the next button is enabled again.

Comment 15

[David :Bienvenu]

I'm not convinced that entering an existing e-mail address is as obvious as not entering anything, or not entering an '@' char. Cc'ing Bryan for his input. But I think the patch looks OK otherwise, and I suspect this stuff will be re-worked with the new auto config stuff anyway...

Comment 16

[David :Bienvenu]

Comment on attachment 339993 [details] [diff] [review]
proposed fix

and we can steal this code for the new auto config :-)

Comment 17

[Bryan Clark (DevTools PM) [:clarkbw]]

Yeah, I'm worried about the lack of feedback.  If a user has POP mail going into the Global Inbox there really isn't any indication of that account existing in the main Thunderbird window.  But I suppose this is how the Account Wizard was designed to interact with people.

For the new account page I think we'll need some kind of string message, possibly in the settings detection area, that lets the person know they already have an account setup for that email.

Comment 18

[Magnus Melin [:mkmelin]]

It wouldn't easily be a global inbox, since the gmail setup creates a separate account to begin with. Sure, the user could have set it up manually.

Do we want this for beta1?

Comment 19

[Bryan Clark (DevTools PM) [:clarkbw]]

If we could get it into b1 we could see what kind of feedback we get.

Comment 20

[Magnus Melin [:mkmelin]]

Ok, lets see if we ca get this landed. Shouldn't rally affect seamonkey since it doesn't ship with any predefined providers.

Comment 21

[Robert Kaiser]

SeaMonkey 2.0a1 has been cut already, tree is open for a2 checkins without approval from our side, you probably need approval from Thunderbird folks though.

Comment 22

[Magnus Melin [:mkmelin]]

changeset:   438:3c5edfef109c
http://hg.mozilla.org/comm-central/rev/3c5edfef109c
->FIXED