378455 - incorrect redirects for in-product links to AMO (wrong language)

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Mike Shaver (:shaver emeritus)]

https://en-us.add-ons.mozilla.com/en-US/firefox/2.0.0.3/extensions/ redirects to https://addons.mozilla.org/es-ES/firefox/browse/type:1 as one example.  Need to get some eyes on the redirect config ASAP, I think.

People are reporting that they sometimes get german, sometimes italian, sometimes spanish when picking the in-product links from Minefield nightlies, too -- not sure if there are different configs on different redirect handlers or some cache wackiness or what.

Comment 1

[Jeremy Orem [:oremj]]

This is the path that the redirects follow.

--10:43:47--  http://en-us.add-ons.mozilla.com/en-US/firefox/2.0.0.3/extensions/
           => `-'
Resolving en-us.add-ons.mozilla.com... 63.245.209.37
Connecting to en-us.add-ons.mozilla.com|63.245.209.37|:80... connected.
HTTP request sent, awaiting response... 
  HTTP/1.1 302 Found
  Age: 313       
  Date: Mon, 23 Apr 2007 17:38:40 GMT
  Connection: Keep-Alive
  Via: NS-CACHE-6.0:   4
  ETag: "KXNHBKKPDLRNRZLR"
  Server: Apache/2.0.52 (Red Hat)
  Location: https://addons.mozilla.org/firefox/extensions/
  Content-Length: 322
  Keep-Alive: timeout=20, max=992
  Content-Type: text/html; charset=iso-8859-1
Location: https://addons.mozilla.org/firefox/extensions/ [following]
--10:43:47--  https://addons.mozilla.org/firefox/extensions/
           => `-'
Resolving addons.mozilla.org... 63.245.209.31
Connecting to addons.mozilla.org|63.245.209.31|:443... connected.
HTTP request sent, awaiting response... 
  HTTP/1.0 302 Found
  Date: Mon, 23 Apr 2007 17:43:47 GMT
  Server: Apache/2.0.52 (Red Hat)
  X-Powered-By: PHP/4.3.9
  Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0, private
  Pragma: no-cache
  Location: https://addons.mozilla.org/en-US/firefox/extensions/
  Content-Length: 0
  Connection: close
  Content-Type: text/html; charset=UTF-8
Location: https://addons.mozilla.org/en-US/firefox/extensions/ [following]
--10:43:47--  https://addons.mozilla.org/en-US/firefox/extensions/

Comment 2

[Jeremy Orem [:oremj]]

So either the addons.mozilla.org redirects are being cached incorrectly at 'https://addons.mozilla.org/firefox/extensions/' or 'http://en-us.add-ons.mozilla.com/en-US/firefox/2.0.0.3/extensions/' needs to redirect to somewhere else.

Comment 3

[Jeremy Orem [:oremj]]

When it was redirecting to es-ES the redirect at https://addons.mozilla.org/en-US/firefox/extensions/ was in the NS cache.

Comment 4

[Jeremy Orem [:oremj]]

Adding the locale into the add-ons.mozilla.com redirect would probably solve this issue. 

Does that sound ok?

Comment 5

[Mike Shaver (:shaver emeritus)]

That sounds like the right thing, yeah, for all the locales that are supported (listed in the dropdown) on AMO.

We should figure out why the NS is caching that redirect, though, because it shouldn't be; that defeats the language detection in a pretty brutal way.  I suspect that we want to just not cache redirects at all for AMO, but I may be forgetting some cases.

Comment 6

[Jeremy Orem [:oremj]]

I think version check sends a 302 to releases.  We would still want to cache that if I am correct.

Comment 7

[Mike Shaver (:shaver emeritus)]

Version check shouldn't be sending a 302, it should be giving back an RDF file.  If we're caching the lang-redirect from the old v2 URLs, we have a serious bug that will give users the wrong language a lot of the time.  Should I file something separate to track that, or just follow it here?

Comment 8

[Jeremy Orem [:oremj]]

Redirect from *.add-ons.mozilla.com is fixed.  I believe there is another bug for the caching problems on addons.mozilla.org