378464 - When session saving is off, opening the application from a link opens too many tab/windows

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[froodian (Ian Leue)]

Presumably a regression from bug 364497.  First reported here: http://forums.mozillazine.org/viewtopic.php?t=542632

STR:

1. Make sure session saving is off.
2. Quit the app.
3. Open the app via a link

What happens: A window is created (with the home page or about:blank, as expected for new windows), and then the URL is opened in a new tab/window (based on the external apps pref)
What should happen: We should only load the URL

A case could be made that when the user has set the pref to open the home page in new windows, this is expected behavior.  However, it's certainly undesired when new windows open to about:blank and then we load the desired URL in a new tab/window regardless.

Comment 1

[Sean Murphy]

(In reply to comment #0)
> Presumably a regression from bug 364497.

Yep, it must be.  I'll take a look and get this behavior back to the way it was before bug 364497.

Comment 2

[Sean Murphy]

Sorry, that closing was accidental.  My palm hit the trackpad right when I was submitting the previous comment and mistakingly performed a click on the FIXED button.

Comment 3

[Sean Murphy]

Attachment: patch

When I moved the application's initialization routines into |ensureInitializationCompleted| as part of bug 364497, I carried along the opening of an initial window and the default browser check as well.  This prompted the start page to load every time because URLs opening during launch have not yet been processed at this point.

Even without the buggy behavior those two steps are best left for applicationDidFinishLaunching anyway, as they're not crucial or required for initialization.

Comment 4

[froodian (Ian Leue)]

Comment on attachment 262532 [details] [diff] [review]
patch

r=me

Comment 5

[Stuart Morgan]

Comment on attachment 262532 [details] [diff] [review]
patch

sr=smorgan

Comment 6

[froodian (Ian Leue)]

Checked in on trunk and MOZILLA_1_8_BRANCH.