Closed Bug 378469 Opened 16 years ago Closed 16 years ago

fix some configure tests in MSMANIFEST_TOOL checking

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

Details

Attachments

(1 file, 1 obsolete file)

+ one more bogus test
1.42 KB, patch
Details | Diff | Splinter Review
Attached patch fix configure logic (obsolete) — — Splinter Review 
The configure logic in the MSMANIFEST_TOOL check uses grep -Po, which is unsupported by MSYS grep, and would be better served by copying the VC version check logic (which uses sed) anyway.  In addition, there's a bogus -z test in that logic, so we never fired the warning, which is why this went unnoticed.

I didn't use _MSVC_VER_FILTER directly in this patch because it only captures 3 version parts, whereas MT has 4.  Dunno if that matters.
Attachment #262507 - Flags: review?(benjamin)
Attachment #262507 - Flags: review?(benjamin) → review+
I missed one bogus test in that patch.
Attachment #262507 - Attachment is obsolete: true
Checked in on trunk.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.