378508 - Convert svg gradients to thebes

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

Attachment: switch gradients to gfxPattern

Comment 1

[Robert Longson [:longsonr]]

Comment on attachment 262557 [details] [diff] [review]
switch gradients to gfxPattern

Needs an update to tip.

Comment 2

[tor]

Attachment: update to tip

Comment 3

[Robert Longson [:longsonr]]

Comment on attachment 262643 [details] [diff] [review]
update to tip

>-nsresult
>-nsSVGGradientFrame::GetGradientTransform(nsIDOMSVGMatrix **aGradientTransform,
>-                                         nsSVGGeometryFrame *aSource)
>+gfxMatrix
>+nsSVGGradientFrame::GetGradientTransform(nsSVGGeometryFrame *aSource)
> {
>-  *aGradientTransform = nsnull;
>+  gfxMatrix result;

result is a rather meaningless name how about bboxMatrix or in fact anything else that gives you a clue to what it is, especially as its definition and use are separated.

with that r=longsonr

Comment 4

[tor]

Attachment: rename matrix

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+gfxPattern *
 nsSVGLinearGradientFrame::CreateGradient()

Shouldn't this addref the pattern and return already_AddRefed<gfxPattern>? returning objects with zero refcount seems like a bad idea.

Otherwise looks good.

Comment 6

[tor]

Attachment: return already_AddRefed patterns

Comment 7

[tor]

Checked in.