Closed Bug 378696 Opened 15 years ago Closed 15 years ago

Remove dead search code

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(3 files)

When working on Bug 121774, I found a lot of dead search code in the DOMi.  This should be canned, and will make Bug 121774's patch much easier to review.
First crack.  I'm going to do this in small chunks to ensure that things work and make sure it's easy to review.
Assignee: dom-inspector → sdwilsh
Status: NEW → ASSIGNED
Attachment #265360 - Flags: superreview?(neil)
Attachment #265360 - Flags: review?(db48x)
Attachment #265360 - Flags: review?(db48x) → review+
(In reply to comment #1)
>I'm going to do this in small chunks
Can you at least give an overview of what you're removing?
Sure.  What I'm removing now is a bunch of commented out code (and a few functions that were only used by that commented out code).  This is all search code that is no longer used.

There are large chunks of code that are not used in DOMi that I want to get rid of, and I know the search stuff is a big chunk of it.

After this patch, I think I'm going to attack the search directory in resources/content as I don't think anything is used in there, but I need to cross reference that.
(In reply to comment #3)
>After this patch, I think I'm going to attack the search directory
Ah, I was assuming you already had a plan at this point, when in fact the reason you're doing this in small chunks is that you don't yet know what you're going to end up removing...
Yeah, sorry.  I don't have a lot of time to work on DOMi stuff, so I'm doing what I can with the little time that I have.  If you want, I can try to get a full fledged plan in place first.
Alright, so I looked into this more this weekend.  It looks to me like everything in extensions/inspector/resources/content/search is no longer used.  I didn't find any consumers of it, nor have I ever come across a UI that looked like it used any of that code.  So, once we get rid of the commented out bits, we can cvs remove the whole directory.
Attachment #265360 - Flags: superreview?(neil) → superreview+
Checking in extensions/inspector/resources/content/inspector.js;
new revision: 1.35; previous revision: 1.34
Checking in extensions/inspector/resources/content/inspectorOverlay.xul;
new revision: 1.12; previous revision: 1.11
Checking in extensions/inspector/resources/content/popupOverlay.xul;
new revision: 1.17; previous revision: 1.16

This bug is not yet fixed.
Target Milestone: --- → mozilla1.9beta
Attachment #265360 - Attachment description: v1.0 → v1.0 (checked in)
This removes the search directory as none of that code is used anymore.
Attachment #270593 - Flags: superreview?(neil)
Attachment #270593 - Flags: review?(db48x)
Attachment #270593 - Flags: review?(db48x) → review+
Attachment #270593 - Flags: superreview?(neil) → superreview+
The last bit is going to be removing the l10n entries that are no longer used.
Comment on attachment 270593 [details] [diff] [review]
v2.0 (checked in)

Checking in jar.mn;
new revision: 1.30; previous revision: 1.29
Removing resources/content/search/inSearchModule.js;
new revision: delete; previous revision: 1.10
Removing resources/content/search/inSearchService.js;
new revision: delete; previous revision: 1.11
Removing resources/content/search/inSearchTreeBuilder.js;
new revision: delete; previous revision: 1.6
Removing resources/content/search/inSearchUtils.js;
new revision: delete; previous revision: 1.7
Removing resources/content/search/modules/popupOverlay.xul;
new revision: delete; previous revision: 1.5
Removing resources/content/search/modules/findFiles/dialog.js;
new revision: delete; previous revision: 1.1
Removing resources/content/search/modules/findFiles/dialog.xul;
new revision: delete; previous revision: 1.7
Removing resources/content/search/modules/junkImgs/dialog.js;
new revision: delete; previous revision: 1.1
Removing resources/content/search/modules/junkImgs/dialog.xul;
new revision: delete; previous revision: 1.7
Removing resources/content/search/modules/junkImgs/junkImgs.xml;
new revision: delete; previous revision: 1.3

This bug is not yet fixed.
Attachment #270593 - Attachment description: v2.0 → v2.0 (checked in)
Whoops.  Missed one...

Removing resources/content/search/modules/findFiles/findFiles.xml;
new revision: delete; previous revision: 1.1
Egads! I forgot to cvs rm another file....

Removing resources/content/search/modules/commandOverlay.xul;
new revision: delete; previous revision: 1.3
Attached patch v3.0Splinter Review
Attachment #271159 - Flags: superreview?(neil)
Attachment #271159 - Flags: review?(db48x)
QA Contact: timeless → dom-inspector
Attachment #271159 - Flags: superreview?(neil) → superreview+
Attachment #271159 - Flags: review?(db48x) → review+
Checking in resources/locale/jar.mn;
new revision: 1.3; previous revision: 1.2
Checking in resources/locale/en-US/inspector.dtd;
new revision: 1.11; previous revision: 1.10
Removing resources/locale/en-US/search/findFiles.dtd;
new revision: delete; previous revision: 1.2
Removing resources/locale/en-US/search/junkImgs.dtd;
new revision: delete; previous revision: 1.2
Checking in resources/locale/fr/inspector.dtd;
new revision: 1.6; previous revision: 1.5
Removing resources/locale/fr/search/findFiles.dtd;
new revision: delete; previous revision: 1.1
Removing resources/locale/fr/search/junkImgs.dtd;
new revision: delete; previous revision: 1.1
Checking in resources/locale/nb-NO/inspector.dtd;
new revision: 1.5; previous revision: 1.4
Removing resources/locale/nb-NO/search/findFiles.dtd;
new revision: delete; previous revision: 1.2
Removing resources/locale/nb-NO/search/junkImgs.dtd;
new revision: delete; previous revision: 1.2
Checking in resources/locale/pl/inspector.dtd;
new revision: 1.6; previous revision: 1.5
Removing resources/locale/pl/search/findFiles.dtd;
new revision: delete; previous revision: 1.1
Removing resources/locale/pl/search/junkImgs.dtd;
new revision: delete; previous revision: 1.1
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.