378696 - Remove dead search code

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Shawn Wilsher :sdwilsh]

When working on Bug 121774, I found a lot of dead search code in the DOMi.  This should be canned, and will make Bug 121774's patch much easier to review.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0 (checked in)

First crack.  I'm going to do this in small chunks to ensure that things work and make sure it's easy to review.

Comment 2

[[e-mail]]

(In reply to comment #1)
>I'm going to do this in small chunks
Can you at least give an overview of what you're removing?

Comment 3

[Shawn Wilsher :sdwilsh]

Sure.  What I'm removing now is a bunch of commented out code (and a few functions that were only used by that commented out code).  This is all search code that is no longer used.

There are large chunks of code that are not used in DOMi that I want to get rid of, and I know the search stuff is a big chunk of it.

After this patch, I think I'm going to attack the search directory in resources/content as I don't think anything is used in there, but I need to cross reference that.

Comment 4

[[e-mail]]

(In reply to comment #3)
>After this patch, I think I'm going to attack the search directory
Ah, I was assuming you already had a plan at this point, when in fact the reason you're doing this in small chunks is that you don't yet know what you're going to end up removing...

Comment 5

[Shawn Wilsher :sdwilsh]

Yeah, sorry.  I don't have a lot of time to work on DOMi stuff, so I'm doing what I can with the little time that I have.  If you want, I can try to get a full fledged plan in place first.

Comment 6

[Shawn Wilsher :sdwilsh]

Alright, so I looked into this more this weekend.  It looks to me like everything in extensions/inspector/resources/content/search is no longer used.  I didn't find any consumers of it, nor have I ever come across a UI that looked like it used any of that code.  So, once we get rid of the commented out bits, we can cvs remove the whole directory.

Comment 7

[Shawn Wilsher :sdwilsh]

Checking in extensions/inspector/resources/content/inspector.js;
new revision: 1.35; previous revision: 1.34
Checking in extensions/inspector/resources/content/inspectorOverlay.xul;
new revision: 1.12; previous revision: 1.11
Checking in extensions/inspector/resources/content/popupOverlay.xul;
new revision: 1.17; previous revision: 1.16

This bug is not yet fixed.

Comment 8

[Shawn Wilsher :sdwilsh]

Attachment: v2.0 (checked in)

This removes the search directory as none of that code is used anymore.

Comment 9

[Shawn Wilsher :sdwilsh]

The last bit is going to be removing the l10n entries that are no longer used.

Comment 10

[Shawn Wilsher :sdwilsh]

Comment on attachment 270593 [details] [diff] [review]
v2.0 (checked in)

Checking in jar.mn;
new revision: 1.30; previous revision: 1.29
Removing resources/content/search/inSearchModule.js;
new revision: delete; previous revision: 1.10
Removing resources/content/search/inSearchService.js;
new revision: delete; previous revision: 1.11
Removing resources/content/search/inSearchTreeBuilder.js;
new revision: delete; previous revision: 1.6
Removing resources/content/search/inSearchUtils.js;
new revision: delete; previous revision: 1.7
Removing resources/content/search/modules/popupOverlay.xul;
new revision: delete; previous revision: 1.5
Removing resources/content/search/modules/findFiles/dialog.js;
new revision: delete; previous revision: 1.1
Removing resources/content/search/modules/findFiles/dialog.xul;
new revision: delete; previous revision: 1.7
Removing resources/content/search/modules/junkImgs/dialog.js;
new revision: delete; previous revision: 1.1
Removing resources/content/search/modules/junkImgs/dialog.xul;
new revision: delete; previous revision: 1.7
Removing resources/content/search/modules/junkImgs/junkImgs.xml;
new revision: delete; previous revision: 1.3

This bug is not yet fixed.

Comment 11

[Shawn Wilsher :sdwilsh]

Whoops.  Missed one...

Removing resources/content/search/modules/findFiles/findFiles.xml;
new revision: delete; previous revision: 1.1

Comment 12

[Shawn Wilsher :sdwilsh]

Egads! I forgot to cvs rm another file....

Removing resources/content/search/modules/commandOverlay.xul;
new revision: delete; previous revision: 1.3

Comment 13

[Shawn Wilsher :sdwilsh]

Attachment: v3.0

Comment 14

[Shawn Wilsher :sdwilsh]

Checking in resources/locale/jar.mn;
new revision: 1.3; previous revision: 1.2
Checking in resources/locale/en-US/inspector.dtd;
new revision: 1.11; previous revision: 1.10
Removing resources/locale/en-US/search/findFiles.dtd;
new revision: delete; previous revision: 1.2
Removing resources/locale/en-US/search/junkImgs.dtd;
new revision: delete; previous revision: 1.2
Checking in resources/locale/fr/inspector.dtd;
new revision: 1.6; previous revision: 1.5
Removing resources/locale/fr/search/findFiles.dtd;
new revision: delete; previous revision: 1.1
Removing resources/locale/fr/search/junkImgs.dtd;
new revision: delete; previous revision: 1.1
Checking in resources/locale/nb-NO/inspector.dtd;
new revision: 1.5; previous revision: 1.4
Removing resources/locale/nb-NO/search/findFiles.dtd;
new revision: delete; previous revision: 1.2
Removing resources/locale/nb-NO/search/junkImgs.dtd;
new revision: delete; previous revision: 1.2
Checking in resources/locale/pl/inspector.dtd;
new revision: 1.6; previous revision: 1.5
Removing resources/locale/pl/search/findFiles.dtd;
new revision: delete; previous revision: 1.1
Removing resources/locale/pl/search/junkImgs.dtd;
new revision: delete; previous revision: 1.1