378751 - memory leak in content/global/config.js (about:config)

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[jcraveiro]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)

When closing the about:config tab, Leak Monitor alerts of a leaked object in chrome://content/global/config.js

Reproducible: Always

Steps to Reproduce:
0. Requires Leak Monitor add-on
1. Open a new tab
2. Write about:config in the address bar
3. Close the tab
Actual Results:  
Leak Monitor alerts of a JavaScript object from a windows that was recently closed  that is still held by native code. 

Expected Results:  
No leaked object.

I tracked that object to the the one initialized in the variable view. I looked at this code:

function onConfigLoad()
{
//etc etc
  document.getElementById("configTree").view = view;
//etc etc
}

function onConfigUnload()
{
  gPrefBranch.removeObserver("", gPrefListener);
  document.getElementById("configTree").view = null;
}

and tried to add view=null after and before document.getElementById("configTree").view=null with no result.

I was using the LeBreeze 2.0.0.2 theme when I detected this, but I switched to the defaut theme and the problems persists.

Comment 1

[Adam Guthrie]

Can you paste the actual object that Leak Monitor reports being leaked?

Comment 2

[jcraveiro]

Leaks in window 0xf355f38:
[+] [leaked object] (1099e350) = [Object]
 [ ] rowCount = true
 [+] getCellText (1099e180, chrome://global/content/config.js, 43-55) = [Function]
  [ ] prototype (8de1ab0) = [Object]
 [+] getRowProperties (1099e160, chrome://global/content/config.js, 58-58) = [Function]
  [ ] prototype (8d877d8) = [Object]
 [+] getCellProperties (1099e130, chrome://global/content/config.js, 59-61) = [Function]
  [ ] prototype (8d87938) = [Object]
 [+] getColumnProperties (1099e0e8, chrome://global/content/config.js, 63-63) = [Function]
  [ ] prototype (8d879e0) = [Object]
 [ ] treebox = null
 [ ] selection (12e4afe0) = [TreeSelection]
 [+] isContainer (1099df40, chrome://global/content/config.js, 66-66) = [Function]
  [ ] prototype (8d87a18) = [Object]
 [+] isContainerOpen (1099de10, chrome://global/content/config.js, 67-67) = [Function]
  [ ] prototype (8d87a80) = [Object]
 [+] isContainerEmpty (1099ddd8, chrome://global/content/config.js, 68-68) = [Function]
  [ ] prototype (8d87ac8) = [Object]
 [+] isSorted (1099dd80, chrome://global/content/config.js, 69-69) = [Function]
  [ ] prototype (8d87b20) = [Object]
 [+] canDrop (1099dd28, chrome://global/content/config.js, 70-70) = [Function]
  [ ] prototype (8d87b48) = [Object]
 [+] drop (1099dcf0, chrome://global/content/config.js, 71-71) = [Function]
  [ ] prototype (8d87b68) = [Object]
 [+] setTree (1099dc40, chrome://global/content/config.js, 72-72) = [Function]
  [ ] prototype (8d87b88) = [Object]
 [+] getParentIndex (1099dc28, chrome://global/content/config.js, 73-73) = [Function]
  [ ] prototype (8d87ba0) = [Object]
 [+] hasNextSibling (1099db88, chrome://global/content/config.js, 74-74) = [Function]
  [ ] prototype (8d87be0) = [Object]
 [+] getLevel (1099db28, chrome://global/content/config.js, 75-75) = [Function]
  [ ] prototype (8d87c28) = [Object]
 [+] getImageSrc (1099dac8, chrome://global/content/config.js, 76-76) = [Function]
  [ ] prototype (8d87cc8) = [Object]
 [+] toggleOpenState (1099dab8, chrome://global/content/config.js, 77-77) = [Function]
  [ ] prototype (8d87d58) = [Object]
 [+] cycleHeader (1099dab0, chrome://global/content/config.js, 78-116) = [Function]
  [ ] prototype (8d87e68) = [Object]
 [+] selectionChanged (1099daa0, chrome://global/content/config.js, 118-118) = [Function]
  [ ] prototype (8d87ee0) = [Object]
 [+] cycleCell (1099da68, chrome://global/content/config.js, 119-119) = [Function]
  [ ] prototype (8d87f70) = [Object]
 [+] isEditable (1099da18, chrome://global/content/config.js, 120-120) = [Function]
  [ ] prototype (8d87fb0) = [Object]
 [+] setCellValue (1099d9b8, chrome://global/content/config.js, 121-121) = [Function]
  [ ] prototype (8d87fe0) = [Object]
 [+] setCellText (1099d9a0, chrome://global/content/config.js, 122-122) = [Function]
  [ ] prototype (8d88098) = [Object]
 [+] performAction (1099d928, chrome://global/content/config.js, 123-123) = [Function]
  [ ] prototype (8d880c8) = [Object]
 [+] performActionOnRow (1099d830, chrome://global/content/config.js, 124-124) = [Function]
  [ ] prototype (8d88450) = [Object]
 [+] performActionOnCell (1099d820, chrome://global/content/config.js, 125-125) = [Function]
  [ ] prototype (8d5f368) = [Object]
 [+] isSeparator (1099d808, chrome://global/content/config.js, 126-126) = [Function]
  [ ] prototype (8d0a5e8) = [Object]

Comment 3

[Adam Guthrie]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070406 BonEcho/2.0.0.4pre

I couldn't reproduce this on Windows. Can you reproduce in safe mode? http://kb.mozillazine.org/Safe_mode

Comment 4

[jcraveiro]

In safe mode, extensios are disabled, which includes Leak Monitor. Is there any other way I can "see the leak happening"?

Comment 5

[Adam Guthrie]

I should've just been straightforward and asked if you're using any other extensions besides Leak Monitor (and if so to disable them and retest). If you're not using any other extensions, could you try reproducing this in a clean profile?

Comment 6

[jcraveiro]

Disabled them, retested, bug reproduced.

Created new (clean) profile, installed only Leak Monitor, retested, bug reproduced.

Comment 7

[Tyler Downer [He/Him]]

This bug is part of a query for Firefox bugs that have Status set to NEW, but have version field set to 2.0 or older and have not changed in over 800 days.

http://tiny.cc/forgottennewbugs

If you still see this bug, or if it is still valid with Firefox 3.6.10 or a firefox 4 nightly build, please update the version field and steps to reproduce.

Comment 8

[Matthias Versen [:Matti]]

Please reopen if this is still an issue