Last Comment Bug 378824 - regression for index() on branches
: regression for index() on branches
Status: RESOLVED FIXED
: fixed1.8.0.12, fixed1.8.1.4
Product: Core
Classification: Components
Component: XForms (show other bugs)
: 1.8 Branch
: x86 All
: -- normal (vote)
: ---
Assigned To: aaronr
: Stephen Pride
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-04-25 18:20 PDT by aaronr
Modified: 2007-04-26 18:18 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (1.09 KB, application/xhtml+xml)
2007-04-25 18:20 PDT, aaronr
no flags Details
testcase (1.21 KB, application/xhtml+xml)
2007-04-25 18:29 PDT, aaronr
no flags Details
patch for 1.8 and 1.8.0 (5.89 KB, patch)
2007-04-25 18:31 PDT, aaronr
bugs: review+
jonas: review+
dveditz: approval1.8.1.4+
dveditz: approval1.8.0.12+
Details | Diff | Review

Description aaronr 2007-04-25 18:20:19 PDT
Created attachment 262829 [details]
testcase

The patch for bug 361501 regressed index() on the 1.8 and 1.8.0 branches.  When index() can't find a repeat it is supposed to return NaN.  Which the new xpath worker function triggers by returning -1.  However, the new worker function returns a PRUint32 and not a PRInt32 so the value doesn't look like it is < 0 so we return 0xffffffff instead of NaN.

I can't believe that I missed that when I reviewed.  Ugh!
Comment 1 aaronr 2007-04-25 18:29:21 PDT
Created attachment 262830 [details]
testcase
Comment 2 aaronr 2007-04-25 18:31:42 PDT
Created attachment 262831 [details] [diff] [review]
patch for 1.8 and 1.8.0
Comment 3 aaronr 2007-04-25 18:35:32 PDT
Comment on attachment 262831 [details] [diff] [review]
patch for 1.8 and 1.8.0

I fixed this by just switching the PRUint32 to a PRInt32 like it used to be.  Sorry again for missing that on review.

Asking olli to review for xforms, jonas for transformiix so that we can get approval for branch checkin.
Comment 4 aaronr 2007-04-26 00:10:35 PDT
Comment on attachment 262831 [details] [diff] [review]
patch for 1.8 and 1.8.0

this will correct a regression caused by a function's signature change  mistakenly made in the branch checkin I did for bug 361501.  Affects only the xforms processor since this is an internal interface only used by xforms
Comment 5 Daniel Veditz [:dveditz] 2007-04-26 16:32:33 PDT
Comment on attachment 262831 [details] [diff] [review]
patch for 1.8 and 1.8.0

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Comment 6 aaronr 2007-04-26 18:18:50 PDT
checked into 1.8 and 1.8.0 branches

Note You need to log in before you can comment on or make changes to this bug.