Compiler warning @ DocumentViewerImpl::PageHide in nsDocumentViewer.cpp

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 262839 [details] [diff] [review]
Add missing return NS_OK

After the landing of bug 374570, the following warning now appears when compiling:

d:\mozbuild\mozilla\layout\base\nsdocumentviewer.cpp(1266) : warning C4715: 'DocumentViewerImpl::PageHide' : not all control paths return a value

Attached patch re-adds the return NS_OK which was removed by that checkin.
Attachment #262839 - Flags: superreview?(bzbarsky)
Attachment #262839 - Flags: review?(bzbarsky)
Comment on attachment 262839 [details] [diff] [review]
Add missing return NS_OK

Do we need this on branches too?  This could be pretty serious...
Attachment #262839 - Flags: superreview?(bzbarsky)
Attachment #262839 - Flags: superreview+
Attachment #262839 - Flags: review?(bzbarsky)
Attachment #262839 - Flags: review+
Assignee: nobody → ryanvm
Fixed.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.