Closed Bug 378827 Opened 14 years ago Closed 14 years ago

Compiler warning @ DocumentViewerImpl::PageHide in nsDocumentViewer.cpp

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ryanvm, Assigned: ryanvm)

References

Details

(Keywords: regression)

Attachments

(1 file)

After the landing of bug 374570, the following warning now appears when compiling:

d:\mozbuild\mozilla\layout\base\nsdocumentviewer.cpp(1266) : warning C4715: 'DocumentViewerImpl::PageHide' : not all control paths return a value

Attached patch re-adds the return NS_OK which was removed by that checkin.
Attachment #262839 - Flags: superreview?(bzbarsky)
Attachment #262839 - Flags: review?(bzbarsky)
Blocks: 374570
Comment on attachment 262839 [details] [diff] [review]
Add missing return NS_OK

Do we need this on branches too?  This could be pretty serious...
Attachment #262839 - Flags: superreview?(bzbarsky)
Attachment #262839 - Flags: superreview+
Attachment #262839 - Flags: review?(bzbarsky)
Attachment #262839 - Flags: review+
Assignee: nobody → ryanvm
Fixed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.