Closed Bug 378829 Opened 15 years ago Closed 12 years ago

"ASSERTION: Creation of FunctionCall failed" with XPath "z()"

Categories

(Core :: XML, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: jruderman, Assigned: sgautherie)

References

()

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached file testcase
###!!! ASSERTION: Creation of FunctionCall failed: 'Error', file /Users/jruderman/trunk/mozilla/content/xslt/src/xpath/txExprParser.cpp, line 490
this assertion is bogus, we should replace this code with NS_ENSURE_SUCCESS(rv, rv)
Assignee: xml → nobody
QA Contact: ashshbhatt → xml
FF and SM 'mochitest-other' builds report this error.

Examples:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269087450.1269089074.27737.gz&fulltext=1
Linux mozilla-central debug test mochitest-other on 2010/03/20 05:17:30
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1269084827.1269088184.24785.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2010/03/20 04:33:47

This assertion happens 3 times.
It might also happen on other tests (builds): I didn't check.

I didn't copy the stack, because I don't know what is interesting in it wrt
this assertion...
Severity: normal → major
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [ToDo: comment 1] [good first bug]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #433734 - Flags: review?(jonas)
Depends on: 206445
Flags: in-testsuite-
Whiteboard: [ToDo: comment 1] [good first bug]
(In reply to comment #1)
> this assertion is bogus, we should replace this code with NS_ENSURE_SUCCESS(rv,
> rv)

http://mxr.mozilla.org/comm-central/source/mozilla/xpcom/glue/nsDebug.h#216
NS_ENSURE_SUCCESS() calls NS_WARNING().

Just to be explicit, what is needed here?
*To remove NS_ERROR() only and keep NS_FAILED()+return.
*To actually replace the block by NS_ENSURE_SUCCESS(),
 which should mean to file a follow-up bug to deal with the warnings...
I think a warning is ok. First off we'll warn higher up in the callstack anyway. Second, it's likely a sign of a bug if we hit that.

So I think the patch is good as is. No need for followup bug.
Comment on attachment 433734 [details] [diff] [review]
(Av1) Remove bogus assertion
[Checkin: Comment 6]


http://hg.mozilla.org/mozilla-central/rev/24f6f5e405f7
Attachment #433734 - Attachment description: (Av1) Remove bogus assertion → (Av1) Remove bogus assertion [Checkin: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed after mozilla1.9.3a4]
Target Milestone: --- → mozilla1.9.3
Whiteboard: [fixed after mozilla1.9.3a4]
Target Milestone: mozilla1.9.3 → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.