378860 - If setAttribute sets an invalid value, the attribute default should be used

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

If setAttribute sets an invalid value, the attribute's default value should be used. In some cases we just continue to use the last valid attribute value. This is follow up to bug 344888.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

How about giving each *AttributesInfo class a Reset(PRUint32 i) method that does the ... .Init (...); dance? Then that code could be shared between UnsetAttr and ParseAttribute.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

... and Init too.

Comment 4

[Robert Longson [:longsonr]]

Attachment: address superreview comments

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 285857 [details] [diff] [review]
address superreview comments

We already do this for some types so this just makes us consistent. Improves spec compliance for SVG. I checked that the croczilla xul pages seem to display correctly.

Comment 6

[Robert Longson [:longsonr]]

checked in.