If setAttribute sets an invalid value, the attribute's default value should be used. In some cases we just continue to use the last valid attribute value. This is follow up to bug 344888.
Created attachment 285088 [details] [diff] [review] patch
Assignee: general → longsonr
Status: NEW → ASSIGNED
Attachment #285088 - Flags: review?(tor)
How about giving each *AttributesInfo class a Reset(PRUint32 i) method that does the ... .Init (...); dance? Then that code could be shared between UnsetAttr and ParseAttribute.
... and Init too.
Created attachment 285857 [details] [diff] [review] address superreview comments
Attachment #285857 - Flags: superreview?(roc) → superreview+
Comment on attachment 285857 [details] [diff] [review] address superreview comments We already do this for some types so this just makes us consistent. Improves spec compliance for SVG. I checked that the croczilla xul pages seem to display correctly.
Attachment #285857 - Flags: approval1.9?
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.