378871 - dragging bookmarks toolbar items while customizing toolbars will silently crash minefield

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Mathieu Pellerin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a4pre) Gecko/20070426 Minefield/3.0a4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a4pre) Gecko/20070426 Minefield/3.0a4pre

Dragging bookmarks toolbar items while customizing toolbars will silently crash latest minefield and output a x window system error message in the terminal:

------------------------
The program 'Gecko' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAlloc (insufficient resources for operation)'.
  (Details: serial 7286 error_code 11 request_code 53 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
------------------------

Reproducible: Always

Steps to Reproduce:
1. Right click on toolbar & select customize menu item
2. Drag the bookmarks toolbar item
Actual Results:  
Kills the fox

Expected Results:  
No crash

This crash has been happening for more than 2-3 weeks now.

Comment 1

[Mathieu Pellerin]

Running on Ubuntu 7.04, X.Org 7.2

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a4pre) Gecko/20070417 Minefield/3.0a4pre

Confirmed with the above build and the 20070426 nightly, running on Ubuntu 06.06 LTS with X.Org 7.0

Comment 3

[Phil Ringnalda (:philor)]

Could someone look up when translucent text dragging landed, and try the build from the day before?

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Phil, do you mean bug 178513 ? The 2007-03-20-04 nightly doesn't crash for me, while the 2007-03-21-04 one does.

Checkins:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-03-20+04%3A00&maxdate=2007-03-21+04%3A00&cvsroot=%2Fcvsroot

Comment 5

[Phil Ringnalda (:philor)]

Yep, bug 178513 is the very one I mean - there must be so much text packed into that single draggable item that it just explodes when you drag it. Or something like that.

Comment 6

[Mathieu Pellerin]

stopped crashing using builds with bookmark places enabled. leaving open as maybe the source of crash should still be investigated.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Not sure why this bug wouldn't be WFM if the code has changed such that the crash no longer happens, though I'm willing to leave it open. Doesn't block, though.

Comment 8

[Boris Zbarsky [:bzbarsky]]

> Not sure why this bug wouldn't be WFM 

Depends on whether the code that crashed is gone, or just not called by in the steps to reproduce (but called in other codepaths).

Comment 9

[Robert Kaiser]

(In reply to Mathieu Pellerin from comment #6)
> stopped crashing using builds with bookmark places enabled. leaving open as
> maybe the source of crash should still be investigated.

Well, you also can't drag toolbar items any more while customization is open, as the whole personal bookmarks stuff is being collapsed into a generic item. And even if you do the dragging in a different window, it doesn't crash, so let's close this.