378903 - Parse errors no longer returned from Refresh

Status: RESOLVED INCOMPLETE

(Core Graveyard :: RDF, defect)

Description

[Dave Townsend [:mossop]]

This is a follow on from bug 99236.

On trunk, since bug 318193 was landed, Refresh only returns any errors from the channel the rdf was loaded from. Previously errors from the rdf parse itself would be passed out allowing for detection of corrupt rdf files.

This is I guess somewhat related to bug 256430

Comment 1

[Dave Townsend [:mossop]]

I'm not going to have time to get to this in the near future unfortunately. Where I have got to is discovering that at http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/rdf/base/src/nsRDFXMLDataSource.cpp&rev=1.158&root=/cvsroot&mark=557#552 rv is NS_OK even with a horribly corrupt rdf file so this is not the easy fix I thought it was. Somehow we have to push errors out from the parser.

This doesn't really make things much worse on trunk as far as localstore.rdf goes. Unlike the branch problem because the rdf parse is returning no error the localstore comes up properly (albeit with perhaps less information than it should) and will correctly flush on shutdown overwriting the damaged file.