378920 - Extension review excerpt and number not showing on main extension page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[CP]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)
Build Identifier: 

Exerts from reviews, and review count, are not appearing on the extensions main page.

https://addons.mozilla.org/en-US/firefox/reviews/display/2144
https://addons.mozilla.org/en-US/firefox/addon/2144

Reproducible: Always

Steps to Reproduce:
none

Comment 1

[Fred Wenzel [:wenzel]]

Yes, excerpts were there once and as it turned out they cluttered the page so they were removed entirely (just like the discussions' content isn't shown either, by the way).

But I am up for suggestions on how to solve this in a good way.

Comment 2

[CP]

The main page of chatzilla (one example among many) contains the content missing in my previous example.
https://addons.mozilla.org/en-US/firefox/addon/16

Comment 3

[Fred Wenzel [:wenzel]]

Ah, I misinterpreted what you were saying. The problem is not something missing *in* the list, but the list entirely missing. Confirming this bug.

Comment 4

[Fred Wenzel [:wenzel]]

Oh. It seems to me like the problem here is that when reviews are added, they get attached to the most recent addon version in the database. If that version happens to be in the sandbox, the review won't show up on the addon display page (but on the review page they will).

As noted in bug 379137, the problem is also visible here:
https://addons.mozilla.org/en-US/firefox/addon/2109

Comment 6

[Fred Wenzel [:wenzel]]

Note that while for bug 379137 I assume it's a sandbox vs. public issue, in the case of this bug, it is likely reviews that are connected to file-less versions which are also not displayed or counted by the addon display page.

Comment 7

[Michael Morgan [:morgamic]]

We should probably show the most recent public version's reviews to go along with the logic for displaying other elements on the display page (like install links, etc.).

Moving forward, it'd be cool to have a tabbed interface to see comments between different versions, in case there is value in it.

Comment 8

[Fred Wenzel [:wenzel]]

A fix for this is in trunk, SVN r3657. It will now only display public reviews on the public page and sandbox+public ones in sandbox mode.

The reviews in the database that refer to versions without files (which they obviously shouldn't) still have to be fixed.

Comment 9

[CP]

I updated the extension, and the review went away, Is it my understanding that only the review for the most recent version?

Comment 10

[Fred Wenzel [:wenzel]]

Has been long fixed.