Closed
Bug 378926
Opened 17 years ago
Closed 17 years ago
support HOST_CMSRCS, HOST_CMMSRCS, .cc files in HOST_CPPSRCS
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file)
|
5.33 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
HOST programs on OSX don't support ObjC files, as it turns out. This patch allows for HOST_CMSRCS and HOST_CMMSRCS, and also allows you to use C++ files ending in .cc in HOST_CPPSRCS. In addition, it respects CPP_PROG_LINK for linking HOST_PROGRAM. Plus I added a few things to the showhost target, just for my sanity's sake.
Attachment #262933 -
Flags: review?(benjamin)
|
||
Updated•17 years ago
|
Attachment #262933 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 1•17 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 2•17 years ago
|
||
Shouldn't this read +ifeq ($(CPP_PROG_LINK),1) + $(HOST_CXX) -o $@ $(HOST_CXXFLAGS) ..... +else + $(HOST_CC) -o $@ $(HOST_CFLAGS) ..... +endif # CPP_PROG_LINK OS/2 build fails when building mar.exe, though the code hasn't changed for several years. The reason is that not all Flags are passed through. Exchanging HOST_CXXFLAGS and HOST_CFLAGS helps to overcome this.
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checked in a fix, thanks for finding that!
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•