Closed
Bug 378928
Opened 19 years ago
Closed 17 years ago
MIDL switch not needed for trunk builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: swsnyder, Assigned: swsnyder)
References
()
Details
Attachments
(1 file)
|
3.22 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The current configure script adds the "-no_robust" switch to the MIDL command line. This switch was needed for compatibility with Windows versions prior to Win2K. Now that Mozilla isn't supporting those older versions, this work-around can be removed for trunk builds (per the comments in the file - see URL above).
|
||
Updated•19 years ago
|
Product: Mozilla Application Suite → Core
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: nobody → swsnyder
Status: NEW → ASSIGNED
|
||
Comment 2•17 years ago
|
||
Comment on attachment 330990 [details] [diff] [review]
Remove Win9x/WinNT4 MIDL work-around
Steve: you forgot to ask for review, which means your patch will sit ignored like... it did.
Attachment #330990 -
Flags: review?(ted.mielczarek)
|
||
Updated•17 years ago
|
Attachment #330990 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 330990 [details] [diff] [review]
Remove Win9x/WinNT4 MIDL work-around
+ MIDL_FLAGS="${MIDL_FLAGS}"
This line has no effect, get rid of it. (The line you copied it from includes ${MIDL_FLAGS} so you can pass that var in from the environment.)
As an aside, wtf is up with your diff?
|
||
Comment 4•17 years ago
|
||
Fixed by bug 271854.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•17 years ago
|
||
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•