If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

MIDL switch not needed for trunk builds

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Steve Snyder, Assigned: Steve Snyder)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
The current configure script adds the "-no_robust" switch to the MIDL command line.  This switch was needed for compatibility with Windows versions prior to Win2K.  Now that Mozilla isn't supporting those older versions, this work-around can be removed for trunk builds (per the comments in the file - see URL above).
Component: Build Config → Build Config
Product: Mozilla Application Suite → Core
(Assignee)

Comment 1

9 years ago
Created attachment 330990 [details] [diff] [review]
Remove Win9x/WinNT4 MIDL work-around
Assignee: nobody → swsnyder
Status: NEW → ASSIGNED
Comment on attachment 330990 [details] [diff] [review]
Remove Win9x/WinNT4 MIDL work-around

Steve: you forgot to ask for review, which means your patch will sit ignored like... it did.
Attachment #330990 - Flags: review?(ted.mielczarek)
Attachment #330990 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 330990 [details] [diff] [review]
Remove Win9x/WinNT4 MIDL work-around

+        MIDL_FLAGS="${MIDL_FLAGS}"

This line has no effect, get rid of it. (The line you copied it from includes ${MIDL_FLAGS} so you can pass that var in from the environment.)

As an aside, wtf is up with your diff?
Fixed by bug 271854.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> Fixed by bug 271854.
Oops, bug 471854. Soory for the spam.
You need to log in before you can comment on or make changes to this bug.