378928 - MIDL switch not needed for trunk builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Steve Snyder]

The current configure script adds the "-no_robust" switch to the MIDL command line.  This switch was needed for compatibility with Windows versions prior to Win2K.  Now that Mozilla isn't supporting those older versions, this work-around can be removed for trunk builds (per the comments in the file - see URL above).

Comment 1

[Steve Snyder]

Attachment: Remove Win9x/WinNT4 MIDL work-around

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 330990 [details] [diff] [review]
Remove Win9x/WinNT4 MIDL work-around

Steve: you forgot to ask for review, which means your patch will sit ignored like... it did.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 330990 [details] [diff] [review]
Remove Win9x/WinNT4 MIDL work-around

+        MIDL_FLAGS="${MIDL_FLAGS}"

This line has no effect, get rid of it. (The line you copied it from includes ${MIDL_FLAGS} so you can pass that var in from the environment.)

As an aside, wtf is up with your diff?

Comment 4

[Masatoshi Kimura [:emk]]

Fixed by bug 271854.

Comment 5

[Masatoshi Kimura [:emk]]

(In reply to comment #4)
> Fixed by bug 271854.
Oops, bug 471854. Soory for the spam.