378995 - remove unsupported Mac widget code from tree

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Mac, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should remove the non-cocoa Mac widget code from the tree, since it's no longer supported now that non-cairo gfx is no longer supported.

This means all of widget/src/mac/ except for nsMacWidget.r (which should probably be moved to widget/src/cocoa/ if still needed) and other files that you should be able to find by looking for (and removing) the relevant build system code, like modules/libpr0n/decoders/icon/mac/nsIconChannel.cpp.

See also bug 376791.

Comment 1

[Josh Aas]

We should definitely remove this for Gecko 1.9 but I'd like to leave it for as long as possible because we are still using it heavily as a reference.

Comment 2

[Stuart Parmenter]

a=me to remove it.

Comment 3

[Josh Aas]

removed on trunk, RIP

Comment 4

[jt.marsh]

Isn't the change to the Makefile broken for srcdir builds? I end up with a nsMacWidget.r being a link pointing to itself.

Comment 5

[Josh Aas]

Attachment: fix v1.0

This should fix srcdir though I haven't tested it myself.

Comment 6

[Ray Kiddy]

So, are you proposing a review for the patch you filed? Do you want assistance with testing it?

Comment 7

[Josh Aas]

I've asked someone on IRC to test it, if it works for him I'll request review. Anyone else who wants to test though is welcome to do it.

Comment 8

[Josh Aas]

Note that word on the street is srcdir build will be completely disabled any day now, so I'd get off of that system ASAP.

Comment 9

[Josh Aas]

srcdir build fix checked in