Closed Bug 378995 Opened 15 years ago Closed 15 years ago

remove unsupported Mac widget code from tree

Categories

(Core Graveyard :: Widget: Mac, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: jaas)

References

Details

Attachments

(1 file)

We should remove the non-cocoa Mac widget code from the tree, since it's no longer supported now that non-cairo gfx is no longer supported.

This means all of widget/src/mac/ except for nsMacWidget.r (which should probably be moved to widget/src/cocoa/ if still needed) and other files that you should be able to find by looking for (and removing) the relevant build system code, like modules/libpr0n/decoders/icon/mac/nsIconChannel.cpp.

See also bug 376791.
We should definitely remove this for Gecko 1.9 but I'd like to leave it for as long as possible because we are still using it heavily as a reference.
a=me to remove it.
removed on trunk, RIP
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Isn't the change to the Makefile broken for srcdir builds? I end up with a nsMacWidget.r being a link pointing to itself.
Attached patch fix v1.0Splinter Review
This should fix srcdir though I haven't tested it myself.
So, are you proposing a review for the patch you filed? Do you want assistance with testing it?
I've asked someone on IRC to test it, if it works for him I'll request review. Anyone else who wants to test though is welcome to do it.
Note that word on the street is srcdir build will be completely disabled any day now, so I'd get off of that system ASAP.
Attachment #276685 - Flags: review?(mark)
Attachment #276685 - Flags: review?(mark) → review+
srcdir build fix checked in
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.