Created attachment 263872 [details] [diff] [review] adds the -profile flag to the output
Comment on attachment 263872 [details] [diff] [review] adds the -profile flag to the output This patch no longer applies, and it's hard to see what you're actually changing. Can you attach an updated diff -uw, assuming those other changes are whitespace only?
Created attachment 303540 [details] Adds and cleans command line arguments for firefox
* Please change OS (Bug is for all OS with command line, not only macos) * update review flag
I think that the 2nd patch is wrong. The -P flag is not the same as the -profile flag. The -P flag takes a name, which is part of the last element of the directory name of the profile directory. It is meant to be displayable in the UI in a user-friendly manner. The -profile flag takes the actual directory, either full path or relative path. The name and the directory are different.
Created attachment 324202 [details] [diff] [review] Adds and cleans command line arguments for firefox u8 patch against current cvs
This new patch still says "-P" == "-profile", which is not true. Please, if I am wrong, let me know.
Created attachment 324345 [details] [diff] [review] command line patch You're right, I've checked and some code comments point out the same thing. The command line currently makes no difference and just call this 'profile'.
Component: Cmd-line Features → Startup and Profile System
Product: Core → Toolkit
QA Contact: startup
Comment on attachment 324345 [details] [diff] [review] command line patch -height and -width are not global options; neither is -inspector. These should not be included in this patch.
Attachment #324345 - Flags: review?(gavin.sharp) → review-
You need to log in before you can comment on or make changes to this bug.