Closed Bug 379045 Opened 13 years ago Closed 13 years ago

Switch svg patterns to thebes

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: tor, Unassigned)

Details

Attachments

(2 files)

No description provided.
Attachment #263034 - Flags: review?(longsonr)
Comment on attachment 263034 [details] [diff] [review]
switch patterns to thebes, remove now unused cleanup call

Seems fine.

>-nsresult
>-nsSVGPatternFrame::GetPatternTransform(nsIDOMSVGMatrix **aPatternTransform)
>+gfxMatrix
>+nsSVGPatternFrame::GetPatternTransform()
> {
...
>     nsCOMPtr<nsIDOMSVGMatrix> patternTransform =
>       nsSVGTransformList::GetConsolidationMatrix(lTrans);
...

Worth having nsSVGTransformList::GetThebesConsolidationMatrix to return a gfxMatrix for use here and in gradients? Would call GetConsolidationMatrix then ConvertSVGMatrixToThebes if the former didn't return null. GetConsolidationMatrix is still used in content so we can't just convert it.

r=longsonr whether or not you go for the suggestion above.
Attachment #263034 - Flags: review?(longsonr) → review+
One other thing though...

> + gfxPlatform::GetPlatform()->CreateOffscreenSurface(gfxIntSize((int)surfaceWidth,
> +                                                                  (int)surfaceHeight),

(int)x should be PRInt32(x) here.
I think the ConsolidateMatrix api addition would be best handled as a separate bug.
Attachment #263054 - Flags: superreview?(roc)
No problem.
Attachment #263054 - Flags: superreview?(roc) → superreview+
Checked in.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.