379045 - Switch svg patterns to thebes

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

Attachment: switch patterns to thebes, remove now unused cleanup call

Comment 1

[Robert Longson [:longsonr]]

Comment on attachment 263034 [details] [diff] [review]
switch patterns to thebes, remove now unused cleanup call

Seems fine.

>-nsresult
>-nsSVGPatternFrame::GetPatternTransform(nsIDOMSVGMatrix **aPatternTransform)
>+gfxMatrix
>+nsSVGPatternFrame::GetPatternTransform()
> {
...
>     nsCOMPtr<nsIDOMSVGMatrix> patternTransform =
>       nsSVGTransformList::GetConsolidationMatrix(lTrans);
...

Worth having nsSVGTransformList::GetThebesConsolidationMatrix to return a gfxMatrix for use here and in gradients? Would call GetConsolidationMatrix then ConvertSVGMatrixToThebes if the former didn't return null. GetConsolidationMatrix is still used in content so we can't just convert it.

r=longsonr whether or not you go for the suggestion above.

Comment 2

[Robert Longson [:longsonr]]

One other thing though...

> + gfxPlatform::GetPlatform()->CreateOffscreenSurface(gfxIntSize((int)surfaceWidth,
> +                                                                  (int)surfaceHeight),

(int)x should be PRInt32(x) here.

Comment 3

[tor]

Attachment: update for comment

I think the ConsolidateMatrix api addition would be best handled as a separate bug.

Comment 4

[Robert Longson [:longsonr]]

No problem.

Comment 5

[tor]

Checked in.