379053 - Cannot send attachments with "%20" in name

Status: RESOLVED WORKSFORME

(MailNews Core :: Attachments, defect)

Description

[Mark Nienberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: version 2.0.0.0 (20070326)

Sending a message with a an attachment that has "%20" in the file name causes this error:

Sending of message failed:
Unable to open the temporary file "blah\blah\file%20name". Check your temporary directory settings.



Reproducible: Always

Steps to Reproduce:
1. Create a file with a name like "test%20file.txt"
2. Attach it to a new message and send.
3.
Actual Results:  
Sending of message failed.

Expected Results:  
Message should send.

Adobe Acrobat creates files with this kind of name and tries to send them via Thunderbird (using MAPI) when inviting others to participate in a browser-based review.  

This was not a problem in versions of Thunderbird prior to 2.0.0. 

Workaround - don't include spaces in filenames that will be sent for review in Acrobat.

Comment 1

[Mark Nienberg]

The problem also occurs with some folder names.  For example, you cannot send a file that is in a folder named "C:\80%CD".  I imagine the %C is being misinterpreted.

Workaround: rename the directory to omit the percent sign.

Comment 2

[WADA:World Anti-bad-Duping Agency]

JFY.
Probably occurs when all strings same as "Escaped Encoding" of RFC2396. 
 ( http://www.faqs.org/rfcs/rfc2396.html )
> 2.4.1. Escaped Encoding
>(snip)
>     escaped     = "%" hex hex
>     hex         = digit | "A" | "B" | "C" | "D" | "E" | "F" |
>                           "a" | "b" | "c" | "d" | "e" | "f"
>Note: digit = "0" | "1" | ... | "9"
And it may be slightly complex than usual when "%25", because it's escaped format of "%". See Bug 93666 for "%25" related problem in the past.

Comment 3

[Magnus Melin [:mkmelin]]

Not a problem on linux... (tried the test%20file.txt)

Comment 5

[Mark Nienberg]

The problem does not occur on Mac OS X 10.3.9.  Guess it is just a Windows thing.

Comment 6

[WADA:World Anti-bad-Duping Agency]

Attachment: Error message when xxxx%20xxxx.txt is attached

(In reply to comment #0)
> Adobe Acrobat creates files with this kind of name and tries to send them via
> Thunderbird (using MAPI) when inviting others to participate in a browser-based
> review.  

> Sending of message failed:
> Unable to open the temporary file "blah\blah\file%20name". Check your temporary
> directory settings.

When latest-trunk of Tb(2007/5/13 build, MS Win-XP SP2, new profile), and when attached file name is "xxxx%20xxxx.txt"(attached by drag&drop instead of thru MAPI), file name in the error message was "xxxx xxxx.txt"(%20 is unescaped to a space).   

Was "blah\blah\file%20name" displayed in error message?
(When MAPI, different escaping/unescaping process from one on drag&drop can occur.)

Comment 7

[Peter Jaspers-Fayer]

Either Drag & Drop, or using te "Attach" dialog, the results were the same:

The Compose window shows (e.g.) "Test%20X.txt", and the error message shows "test X.txt".

Comment 8

[Peter Jaspers-Fayer]

Attachment: Shows translation of file name in Windows

Sorry, did not see how to add attachmment to comment, so I did this after.

Comment 9

[WADA:World Anti-bad-Duping Agency]

Same test result as comment #6 with Seamonkey latest-trunk(2007/5/15 build,ZIP).
Changing to Produnt=Core.

Comment 10

[WADA:World Anti-bad-Duping Agency]

Confirming based on test result in commnent #6, comment #7 and comment #9.

Comment 12

[Edwin Slonim]

Attachment: Screen shot of bug with Hebrew filename

Example of same failure when attaching a file with a Hebrew filenames
The filename in hex was:
file:///C:/Users/Itay/Documents/Updater5/%D7%94%D7%A9%D7%99%D7%97%D7%94%20%D7%A2%D7%9D%20%D7%A1%D7%99%D7%9C%D7%91%D7%99.doc

Windows Vista system

Comment 13

[Mathew]

I came across this error trying to attach pictures in b:\My%20Pictures\. b: is a mapped network drive to a linux server.

As a work-around I created My Pictures as a symbolic link to My%20Pictures and this resolved the issue. I vaguely remember renaming My Pictures to My%20Pictures to resolve an issue with an earlier version of Thunderbird (1.x.x)

Comment 14

[OstGote!]

(In reply to comment #12)
> Created an attachment (id=281491) [details]
> Screen shot of bug with Hebrew filename
> 
> Example of same failure when attaching a file with a Hebrew filenames

non-ascii chars in filename/path is Bug 332110 (and Bug 234681)

Comment 15

[WADA:World Anti-bad-Duping Agency]

Root problem looks to be Bug 397815.
Setting 397815 in dependency. Please remove, if it's wrong.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Bug 397815 is a Firefox bug.

Comment 17

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #16)
> Bug 397815 is a Firefox bug.
Gavin, decoding/encoding URI(and escaping/unescaping) is common function(core issue), isn't it? 

Comment 18

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #17)
> (In reply to comment #16)
> > Bug 397815 is a Firefox bug.
> Gavin, decoding/encoding URI(and escaping/unescaping) is common function(core
> issue), isn't it? 

Firefox also uses core functions to do decoding/encoding, sure, but bug 397815 isn't about a bug in the core functions. It's about a bug in Firefox that's not using them correctly. It's not related to a mailnews bug at all.

Comment 19

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #18)
> bug 397815 isn't about a bug in the core functions. 
> It's about a bug in Firefox that's not using them correctly.

Gavin, thanks for your explanation.
This bug is probably problem that Tb doesn't use them correctly.

Comment 20

[Przemyslaw Bialik]

WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1pre) Gecko/2008063003 Thunderbird/3.0a2pre ID:2008063003

Comment 23

[Wayne Mery (:wsmwk)]

everyone agree this is fixed in TB3 beta?  (ref comment 20)

Comment 24

[WADA:World Anti-bad-Duping Agency]

> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090915 Shredder/3.0b4pre

Shredder/3.0b4pre didn't produce error, generated next header, and file content was  attached.
> Content-Disposition: attachment; filename="txt X%20Y.txt"

Comment 25

[Wayne Mery (:wsmwk)]

WFM also, and quite sure this is a dupe.