379127 - Incorrect link to the documentation when trying to view an nonexistent saved search

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Dmitry Cherkasov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: Bugzilla 3.0rc1

The following files:
template/en/default/global/code-error.html.tmpl
template/en/default/global/user-error.html.tmpl
contain reference to non-existing file:
docs/html/list.html

This file (list.html) existed in previous versions and the reference has been probably inherited from them.

Reproducible: Always

Steps to Reproduce:
1. Create URL that tries to use stored search with invalid name.
2. You obtain a page with error description. On the right part of the page there are links under the title "Related documentation"
3. Try second link "Bugs lists"
Actual Results:  
Not Found

The requested URL /docs/html/list.html was not found on this server.

Expected Results:  
Probably there should be link to /docs/html/query.html#list

Comment 1

[Frédéric Buclin]

You have to go to editparams.cgi?section=core#docs_urlbase and set the 'docs_urlbase' parameter correctly, e.g. write "http://www.bugzilla.org/docs/html/".

Comment 2

[Teemu Mannermaa (:wicked)]

This works on trunk but on 3.0 branch there is no list.html doc page. Pointing to trunk docs from 3.0 branch is not a good idea anyway. Besides, docs can come from locally build versions too.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

The right page is query.html#list for both 3.0 and 3.1.

Comment 4

[Marc Schumann [:Wurblzap]]

Comment on attachment 267007 [details] [diff] [review]
patch, v1

r=Wurblzap by looking at a 3.0 tarball and finding the anchor there. (I don't know how to build the docs myself.)

Comment 5

[Frédéric Buclin]

Attachment: patch, v2

I found other places calling list.html. Fixing them as well.

Comment 6

[Frédéric Buclin]

Marc, you don't need to compile the docs yourself (I'm unable to do it myself either). All you have to do is to set docs_urlbase = http://www.bugzilla.org/docs/html/

Comment 7

[Marc Schumann [:Wurblzap]]

Comment on attachment 267010 [details] [diff] [review]
patch, v2

Thanks for the hint!

If you want, remove the "About" at query_name_missing and carry forward r+. All the other places you found simply link to "Bug lists".

Comment 8

[Frédéric Buclin]

I removed "About" on checkin.

tip:

Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v  <--  code-error.html.tmpl
new revision: 1.96; previous revision: 1.95
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.212; previous revision: 1.211
done


3.0:

Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v  <--  code-error.html.tmpl
new revision: 1.92.2.2; previous revision: 1.92.2.1
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.204.2.3; previous revision: 1.204.2.2
done