37915 - plugin ref count leak in nsPluginHostImpl.cpp

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[sean echevarria]

There should be a release in nsPluginHostImpl::InstantiateEmbededPlugin()  
before the return at 
http://lxr.mozilla.org/seamonkey/source/modules/plugin/nglsrc/nsPluginHostImpl.c
pp#1523 - without it, stopped plugins get leaked when you return to a page with 
a plugin that you've already been to.

    aOwner->GetInstance(instance);
    if(!aMimeType || PL_strcasecmp(aMimeType, "application/x-java-vm"))
        rv = NewEmbededPluginStream(aURL, nsnull, instance);
    NS_IF_RELEASE(instance);
    return NS_OK;
    }

Comment 1

[av (gone)]

Thanks for the catch. I think the same thing is happening in 
nsPluginHostImpl::InstantiateFullPagePlugin(). I'll check in the fix as soon as 
the tree is open.

Comment 2

[av (gone)]

Done

Comment 3

[shrirang khanzode]

verified changes in file nsPluginHostImpl.cpp.