379167 - [BeOS] Thebes gfx changes not included in BeOS code

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Doug Shelton]

Changes incorporated in Thebes platform-specific gfx code from bug 375446 and bug  332115 were not incorporated into gfxBeOSPlatform code.  BeOS building breaks at building gfxPlatform.cpp

Need to incorporate changes in gfxBeOSPlatform.h and gfxBeOSPlatform.cpp

Comment 1

[Doug Shelton]

Attachment: changes to allow gfxPlatform to build

Based on code changes to gfxPlatformGtk.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 263197 [details] [diff] [review]
changes to allow gfxPlatform to build

-    already_AddRefed<gfxASurface>
-        CreateOffscreenSurface(PRUint32 width,
-                               PRUint32 height,
-                               gfxASurface::gfxImageFormat imageFormat);
+    already_AddRefed<gfxASurface> CreateOffscreenSurface(const gfxIntSize& size,
+                                                         gfxASurface::gfxImageFormat imageFormat);
 
Your lines are really long now... can you format them more like the original code?

Hm, is this patch really enough? You don't have to change the implementation of CreateOffscreenSurface in the .cpp file?

Comment 3

[Doug Shelton]

I'll reformat, no problem.  I copied the code from the gtk version, formatting and all.  We may need to change the .cpp file also in order for the code to function correctly but this patch at least gets past the build problems.  Once I get a working build, I'm sure there will be more work to do.

Comment 4

[Doug Shelton]

Attachment: revised formatting per biesi's request

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 263458 [details] [diff] [review]
revised formatting per biesi's request

gfxBeOSPlatform.cpp has a gfxPlatformGtk::... member function declared (copy-paste error?).. in any case, you don't need review from me for BeOS-only code.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

if you don't make the cpp change that I mentioned gfxPlatformBeOS.cpp can't be compiled. vlad's comment is something else that'd break that file. I guess there's another build breakage before that file is reached...

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

BeOS is dead.