[BeOS] Thebes gfx changes not included in BeOS code

RESOLVED WONTFIX

Status

()

--
major
RESOLVED WONTFIX
12 years ago
7 years ago

People

(Reporter: doug, Assigned: doug)

Tracking

Trunk
x86
BeOS
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
Changes incorporated in Thebes platform-specific gfx code from bug 375446 and bug  332115 were not incorporated into gfxBeOSPlatform code.  BeOS building breaks at building gfxPlatform.cpp

Need to incorporate changes in gfxBeOSPlatform.h and gfxBeOSPlatform.cpp
(Assignee)

Updated

12 years ago
Blocks: 356310
(Assignee)

Comment 1

12 years ago
Created attachment 263197 [details] [diff] [review]
changes to allow gfxPlatform to build

Based on code changes to gfxPlatformGtk.
Assignee: nobody → doug
Status: NEW → ASSIGNED
(Assignee)

Updated

12 years ago
Attachment #263197 - Flags: review?(cbiesinger)
Comment on attachment 263197 [details] [diff] [review]
changes to allow gfxPlatform to build

-    already_AddRefed<gfxASurface>
-        CreateOffscreenSurface(PRUint32 width,
-                               PRUint32 height,
-                               gfxASurface::gfxImageFormat imageFormat);
+    already_AddRefed<gfxASurface> CreateOffscreenSurface(const gfxIntSize& size,
+                                                         gfxASurface::gfxImageFormat imageFormat);
 
Your lines are really long now... can you format them more like the original code?

Hm, is this patch really enough? You don't have to change the implementation of CreateOffscreenSurface in the .cpp file?
(Assignee)

Comment 3

12 years ago
I'll reformat, no problem.  I copied the code from the gtk version, formatting and all.  We may need to change the .cpp file also in order for the code to function correctly but this patch at least gets past the build problems.  Once I get a working build, I'm sure there will be more work to do.
(Assignee)

Comment 4

12 years ago
Created attachment 263458 [details] [diff] [review]
revised formatting per biesi's request
Attachment #263197 - Attachment is obsolete: true
Attachment #263197 - Flags: review?(cbiesinger)
(Assignee)

Updated

12 years ago
Attachment #263458 - Flags: review?(vladimir)
Comment on attachment 263458 [details] [diff] [review]
revised formatting per biesi's request

gfxBeOSPlatform.cpp has a gfxPlatformGtk::... member function declared (copy-paste error?).. in any case, you don't need review from me for BeOS-only code.
Attachment #263458 - Flags: review?(vladimir) → review-
if you don't make the cpp change that I mentioned gfxPlatformBeOS.cpp can't be compiled. vlad's comment is something else that'd break that file. I guess there's another build breakage before that file is reached...

Updated

10 years ago
Blocks: 430829

Updated

10 years ago
No longer blocks: 430829
BeOS is dead.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.