The moz_annos table is created w/o the type column; worst, the tests pass because we apparently run migration code for new profiles (should I file that separately?)
Created attachment 263219 [details] [diff] [review] wip
Assignee: dietrich → mano
Status: NEW → ASSIGNED
Created attachment 263250 [details] [diff] [review] wip
Attachment #263219 - Attachment is obsolete: true
Created attachment 263294 [details] [diff] [review] set schema version on profile creation patch to add the column, and not run migration code for new profiles mano, should your wip patches here be on bug 379211?
Comment on attachment 263250 [details] [diff] [review] wip oops, yeah, sorry, f***, etc.
Attachment #263250 - Attachment is obsolete: true
11 years ago
Assignee: mano → dietrich
Status: ASSIGNED → NEW
Created attachment 263332 [details] [diff] [review] fix v2 if moz_places hasn't been created, set the db schema version.
Attachment #263332 - Flags: review?(mano)
Comment on attachment 263332 [details] [diff] [review] fix v2 r=mano just to get this working; we could improve the perf of this code a little.
Attachment #263332 - Flags: review?(mano) → review+
Checking in toolkit/components/places/src/nsAnnotationService.cpp; /cvsroot/mozilla/toolkit/components/places/src/nsAnnotationService.cpp,v <-- nsAnnotationService.cpp new revision: 1.19; previous revision: 1.18 done Checking in toolkit/components/places/src/nsNavHistory.cpp; /cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v <-- nsNavHistory.cpp new revision: 1.120; previous revision: 1.119 done Checking in toolkit/components/places/src/nsNavHistory.h; /cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.h,v <-- nsNavHistory.h new revision: 1.76; previous revision: 1.75 done test pending review
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Comment on attachment 263496 [details] [diff] [review] test I don't think to test this given that the fix here is mainly for correctness, and that your test would pass regardless of this patch. Also, I would bet that various tests in test_annotations.js would fail if the annotations table doesn't have the type column.
Attachment #263496 - Flags: review?(mano) → review-
11 years ago
Flags: in-testsuite? → in-testsuite-
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.