Closed Bug 379240 Opened 14 years ago Closed 14 years ago

Version/config bumps for Fx/Tb 150twelve

Categories

(Firefox Build System :: General, defect)

1.5.0.x Branch
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: rhelmer)

Details

Attachments

(13 files, 4 obsolete files)

15.59 KB, patch
rhelmer
: review+
Details | Diff | Splinter Review
17.83 KB, patch
rhelmer
: review+
Details | Diff | Splinter Review
2.47 KB, patch
rhelmer
: review+
Details | Diff | Splinter Review
3.68 KB, patch
preed
: review+
Details | Diff | Splinter Review
2.47 KB, patch
rhelmer
: review+
Details | Diff | Splinter Review
9.06 KB, patch
rhelmer
: review+
Details | Diff | Splinter Review
5.39 KB, patch
preed
: review+
Details | Diff | Splinter Review
2.03 KB, patch
preed
: review+
Details | Diff | Splinter Review
7.00 KB, patch
rhelmer
: review+
Details | Diff | Splinter Review
5.62 KB, patch
preed
: review+
Details | Diff | Splinter Review
6.07 KB, patch
Details | Diff | Splinter Review
1.79 KB, patch
preed
: review+
Details | Diff | Splinter Review
3.16 KB, patch
nthomas
: review+
Details | Diff | Splinter Review
Tracking bug for version and config bumps for the Firefox & Thunderbird 1.5.0.12 releases.
Attachment #263282 - Flags: review?(rhelmer) → review+
Attachment #263284 - Flags: review?(rhelmer) → review+
Attachment #263295 - Flags: review?(rhelmer)
Comment on attachment 263353 [details] [diff] [review]
Fx/Tb - version bumps and client.mk changes

r=preed; a=preed to land on the GECKO180_20070501_RELBRANCH.
Attachment #263353 - Flags: review?(preed) → review+
Attachment #263389 - Flags: review?(rhelmer)
Attachment #263389 - Flags: review?(rhelmer) → review+
Attachment #263295 - Flags: review?(rhelmer) → review+
Notes:
 - shipped-locales unchanged for both apps
 - I changed testurl to betatest-url in the Tb -> complete-update -> partial. This seemed to be the odd one out
Attachment #263571 - Flags: review?(preed)
Updates for RC1 were never generated, so the previous patch is obsolete. Changes from that to this one are s/rc1/rc2/ in appropriate places, and updated BuildIDs.
Attachment #263571 - Attachment is obsolete: true
Attachment #264279 - Flags: review?(rhelmer)
Attachment #263571 - Flags: review?(preed)
Attachment #264279 - Flags: review?(rhelmer) → review+
Apparently we are going to push RCs on beta to the 1.5.0.x apps as well as 2.0.0.4
Attachment #264494 - Flags: review?(rhelmer)
Sorry, I had beta instead of beta-url in one place.
Attachment #264494 - Attachment is obsolete: true
Attachment #264497 - Flags: review?(rhelmer)
Attachment #264494 - Flags: review?(rhelmer)
Attachment #264497 - Attachment is obsolete: true
Attachment #265552 - Flags: review?(preed)
Attachment #264497 - Flags: review?(rhelmer)
Attachment #265552 - Attachment is obsolete: true
Attachment #265727 - Flags: review?(preed)
Attachment #265552 - Flags: review?(preed)
Attachment #265727 - Flags: review?(preed) → review+
Apologies for the churn here, but we need this to fix the snippets for the release tomorrow. The ones waiting on the staging box use bouncer2, and we need to undo the parts of the config that generate snippets for the beta channel.
Attachment #266504 - Flags: review?(preed)
(In reply to comment #13)
> Created an attachment (id=266504) [details]
> Tb - moz180-branch-patcher2.cfg changes for RC2 - take V - bouncer1
> 
> Apologies for the churn here, but we need this to fix the snippets for the
> release tomorrow. The ones waiting on the staging box use bouncer2,

We can probably get IT to create a CNAME for bouncer2, but then I don't see that being fixed here.

> and we need
> to undo the parts of the config that generate snippets for the beta channel.

Why?
Comment on attachment 266504 [details] [diff] [review]
Tb - moz180-branch-patcher2.cfg changes for RC2 - take V - bouncer1

Yah, for Thunderbird 1.8.0-branch, this makes sense; you might include in the comment that you removed these because they were never used, and you're just updating the config to reflect that. That's what I was missing.
Attachment #266504 - Flags: review?(preed) → review+
Attachment #266665 - Flags: review?(rhelmer) → review+
Attachment #266813 - Flags: review?(preed)
Attachment #266814 - Flags: review?(preed)
Comment on attachment 266813 [details] [diff] [review]
partner patcher config

Looks good!
Attachment #266813 - Flags: review?(preed) → review+
Attached patch a few typosSplinter Review
Sorry, missed a few spots; try this on for size (already landed the previous)
Attachment #266828 - Flags: review?(preed)
Attachment #266828 - Flags: review?(preed) → review+
Attachment #266926 - Flags: review?(nrthomas)
Comment on attachment 266926 [details] [diff] [review]
bump 15012 block for yahoo

Patch looks good. I had a look at the rest of the config to do the review, and this doesn't right:
(release block for 1.5.0.12):

    <platforms>
      win32      = 2007050903
      linux-i686 = 2007050903
      mac        = 2007050815
    </platforms>

Only the mac one is right, use 2007050813 for the other two I think.
Attachment #266926 - Flags: review?(nrthomas) → review+
(In reply to comment #22)
> (From update of attachment 266926 [details] [diff] [review])
> Patch looks good. I had a look at the rest of the config to do the review, and
> this doesn't right:
> (release block for 1.5.0.12):
> 
>     <platforms>
>       win32      = 2007050903
>       linux-i686 = 2007050903
>       mac        = 2007050815
>     </platforms>
> 
> Only the mac one is right, use 2007050813 for the other two I think.
> 

Yep you got it, thanks! Fixing it now.
Re-assigning to rhelmer for partner repacks.
Assignee: nrthomas → rhelmer
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 266814 [details] [diff] [review]
verification for partner updates

Canceling review; these already went out.
Attachment #266814 - Flags: review?(preed)
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.