379267 - Rendering issue when using vertical-align ignoring parent line-height

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Kim Love]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a4) Gecko/20070427 GranParadiso/3.0a4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a4) Gecko/20070427 GranParadiso/3.0a4

It seems that GPa4 is ignoring the line-height of a parent element when setting an (inline) child with negative percentage value (i.e. vertical-align:-15%).

See url for a demo (cut out of our development website, so code is a bit messy).

Firefox 2 seems to get it correct. 

Also occurring in Minefield 3.0a5pre


Reproducible: Didn't try

Steps to Reproduce:
I've not tried to reproduce it under different layout circumstances, (deadlines to meet) but seems to be a fairly predictable rendering issue - probably best to check the url


Expected Results:  
Setting negative % values on an inline element should be relative to the parents' line-height (at least that what seems to happen in other browsers!)

Firefox 2 seems to show the correct behavior :)

about:buildconfig

Build platform
target
i686-pc-cygwin

Build tools
Compiler 	Version 	Compiler flags
$(CYGWIN_WRAPPER) cl 	14.00.50727 	-TC -nologo -W3 -Gy -Fd$(PDBFILE)
$(CYGWIN_WRAPPER) cl 	14.00.50727 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fd$(PDBFILE)

Configure arguments
--enable-application=browser --enable-update-channel=beta --enable-optimize --disable-debug --disable-tests --enable-static --disable-shared --enable-svg --enable-canvas --enable-default-toolkit=cairo-windows --enable-update-packaging --with-branding=browser/branding/unofficial

Comment 1

[Steve England [:stevee]]

Going by the example in the URL, this changed behaviour between:

Works
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a2pre) Gecko/2007012202 Minefield/3.0a2pre

Broken
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a2pre) Gecko/2007012304 Minefield/3.0a2pre

Regression Range
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-01-22+01&maxdate=2007-01-23+05&cvsroot=%2Fcvsroot

Comment 2

[Martijn Wargers (dead)]

That makes it probably a regression of bug 367332.
With a quick view, this looks related/the same as bug 368545.

Comment 3

[Kim Love]

I've chucked together a simplified html demo: (not quite a testcase, but may help?)

http://www.kimlove.com/bug/30a4_bug2.html

Behaviour between Firefox 2.0.0.3 and Gran Paradiso a4 is identical, but Opera 9.20 seems to be doing things differently, but can't say which is correct (sorry!).

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The testcase at that URL today is different from what it was a few weeks ago.  And the one that's there today has a width such that at my font size, the image wraps.  Could you attach a testcase to the bug that doesn't require external files, and won't go away or change?

Comment 5

[dolphinling]

Testcase is now 404, comment 2 says possibly the same as another bug marked WFM. Is this still an issue, or -> WORKSFORME?

Comment 6

[Michelle Funches - QA]

As related bugs are fixed; the attach test case is no longer valid, and comment 5 has not been answered, I will close this as Resolved-Worksforme.
If anyone can still reproduce it, feel free to reopen the issue and provide updated steps/links.